[vcpkg baseline][llfio] Fix arm build#23166
Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
Closed
[vcpkg baseline][llfio] Fix arm build#23166JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/llfio/vcpkg.json
Valid values for the license field can be found in the documentation
| if(CMAKE_CXX_STANDARD) | ||
| if(MSVC) | ||
| - set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} /std:c++${CMAKE_CXX_STANDARD}") | ||
| + set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} /std:c++${CMAKE_CXX_STANDARD} /MTd") |
Contributor
There was a problem hiding this comment.
While this may fix the issue, it does not seem at all like something that should be specific to llfio. We need to determine the underlying cause of this break and fix it generally instead of patching this specific library.
Contributor
|
Closing in favor of #23176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
Related: #23001