Skip to content

[sfml] Add arm64 patch to allow SFML to compile on apple silicon#22937

Merged
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
pierr3:master
Feb 4, 2022
Merged

[sfml] Add arm64 patch to allow SFML to compile on apple silicon#22937
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
pierr3:master

Conversation

@pierr3
Copy link
Contributor

@pierr3 pierr3 commented Feb 4, 2022

Describe the pull request

  • What does your PR fix?

    Fixes issue with SFML that blocks compiling on arm64 systems, although supported. See SFML Issue 1749 SFML Issue 1749 and SFML PR 1750

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    arm64-osx, No

  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Submission containing materials of a third party: jkeller51

@ghost
Copy link

ghost commented Feb 4, 2022

CLA assistant check
All CLA requirements met.

@pierr3 pierr3 marked this pull request as draft February 4, 2022 13:10
@pierr3 pierr3 marked this pull request as ready for review February 4, 2022 13:35
@strega-nil-ms
Copy link
Contributor

Thank you!

@strega-nil-ms strega-nil-ms merged commit 666afd1 into microsoft:master Feb 4, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sfml/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 5, 2022
* master: (221 commits)
  [vcpkg-tool] update to 2022-02-03 (microsoft#22924)
  [opencv4] Disable building cpufeatures since it conflict with libwebp (microsoft#22844)
  [rhasheq] New port (microsoft#22905)
  [sfml] Add arm64 patch to allow SFML to compile on apple silicon (microsoft#22937)
  [popsift] Fix missing Thrust include, already merged upstream. (microsoft#22929)
  [python3][python2] Use MKDIR_P to create directories to avoid race conditions (microsoft#22902)
  Added libe57format port (microsoft#22909)
  update polyhook2 (microsoft#22906)
  [botan] Fix debug info (microsoft#22911)
  [opentelemetry-cpp] update version to v1.2.0 (microsoft#22925)
  [docs] document VCPKG_INSTALLED_DIR variable (microsoft#22695)
  [c89stringutils] New port (microsoft#22904)
  [randomstr] New port (microsoft#22921)
  [docs] Add Authoring-script-ports.md (microsoft#22396)
  [vcpkg_fail_port_install] Deprecate function (microsoft#21489)
  [vcpkg-cmake-config] add missing TOOLS_PATH (microsoft#22863)
  Ace Build Windows - Missing files in include package (microsoft#22880)
  [opendnp3] Disable FetchContent in favor of predownloading (microsoft#22894)
  libraqm update to 0.9.0 (microsoft#22907)
  [google-cloud-cpp] update to latest release (v1.36.0) (microsoft#22897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants