Skip to content

[opendnp3] Disable FetchContent in favor of predownloading#22894

Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
ras0219-msft:dev/roschuma/opendnp3
Feb 3, 2022
Merged

[opendnp3] Disable FetchContent in favor of predownloading#22894
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
ras0219-msft:dev/roschuma/opendnp3

Conversation

@ras0219-msft
Copy link
Contributor

opendnp3 currently uses FetchContent to get dependencies which violates vcpkg policy. This PR:

  1. Actually uses the vcpkg asio dependency
  2. Elevates the downloads of exe4cpp and ser4cpp to the portfile, ensuring that the use adheres to all of our policies (proxies, asset caching, etc). These libraries are not currently in vcpkg so it isn't pressing to de-vendor them at this time.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opendnp3/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Feb 3, 2022
@strega-nil-ms
Copy link
Contributor

Thanks robert! I know we discussed making this support --head, but I don't think it's important unless and until we get someone asking after it, since it's kind of a pain.

@strega-nil-ms strega-nil-ms merged commit ffda730 into microsoft:master Feb 3, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 5, 2022
* master: (221 commits)
  [vcpkg-tool] update to 2022-02-03 (microsoft#22924)
  [opencv4] Disable building cpufeatures since it conflict with libwebp (microsoft#22844)
  [rhasheq] New port (microsoft#22905)
  [sfml] Add arm64 patch to allow SFML to compile on apple silicon (microsoft#22937)
  [popsift] Fix missing Thrust include, already merged upstream. (microsoft#22929)
  [python3][python2] Use MKDIR_P to create directories to avoid race conditions (microsoft#22902)
  Added libe57format port (microsoft#22909)
  update polyhook2 (microsoft#22906)
  [botan] Fix debug info (microsoft#22911)
  [opentelemetry-cpp] update version to v1.2.0 (microsoft#22925)
  [docs] document VCPKG_INSTALLED_DIR variable (microsoft#22695)
  [c89stringutils] New port (microsoft#22904)
  [randomstr] New port (microsoft#22921)
  [docs] Add Authoring-script-ports.md (microsoft#22396)
  [vcpkg_fail_port_install] Deprecate function (microsoft#21489)
  [vcpkg-cmake-config] add missing TOOLS_PATH (microsoft#22863)
  Ace Build Windows - Missing files in include package (microsoft#22880)
  [opendnp3] Disable FetchContent in favor of predownloading (microsoft#22894)
  libraqm update to 0.9.0 (microsoft#22907)
  [google-cloud-cpp] update to latest release (v1.36.0) (microsoft#22897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants