[benchmark] Remove vcpkg_fail_port_install.#22728
Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom Jan 24, 2022
Merged
[benchmark] Remove vcpkg_fail_port_install.#22728strega-nil-ms merged 1 commit intomicrosoft:masterfrom
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
Conversation
A comment was moved from portfile.cmake to vcpkg.json. In support of microsoft#21502
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/benchmark/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Thanks! |
strega-nil-ms
pushed a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jan 24, 2022
JonLiu1993
added
the
category:port-bug
strega-nil-ms
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Bulk remove vcpkg_fail_port_install calls. Interesting ones have been split out into separate reviews, where "interesting" means "anything more than just deleting the call to vcpkg_fail_port_install", In support of #21502 * Update version database. * Revert google benchmark changes already submitted as #22728 * Repair version database.
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jan 27, 2022
A comment was moved from portfile.cmake to vcpkg.json. In support of microsoft#21502
BillyONeal
added a commit
that referenced
this pull request
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment was moved from portfile.cmake to vcpkg.json.
In support of #21502