Skip to content

[netcdf-c] Fix build under Linux with dynamic linkage#19981

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
Osyotr:netcdf_c_linux_dynamic
Sep 14, 2021
Merged

[netcdf-c] Fix build under Linux with dynamic linkage#19981
BillyONeal merged 4 commits intomicrosoft:masterfrom
Osyotr:netcdf_c_linux_dynamic

Conversation

@Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Sep 3, 2021

The fix is basically the same as in #19126.
gdal depends on netcdf-c since #17698, so it is also fixed.
x64-linux-dynamic: build OK
x64-windows: build OK

@JonLiu1993 JonLiu1993 self-assigned this Sep 6, 2021
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 6, 2021
JonLiu1993
JonLiu1993 suggested changes Sep 6, 2021
View reviewed changes
@Osyotr Osyotr force-pushed the netcdf_c_linux_dynamic branch from 85c644c to 467b24e Compare September 6, 2021 15:29
@Osyotr Osyotr requested a review from JonLiu1993 September 6, 2021 15:32
@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 7, 2021
BillyONeal
BillyONeal reviewed Sep 8, 2021
View reviewed changes
@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Sep 8, 2021
@BillyONeal
Copy link
Member

BillyONeal commented Sep 8, 2021

I'm marking this with requires:vcpkg-team-review because we need to decide whether we want to change the lint check in the tool (which will make this change irrelevant) vs. accept this as is.

@BillyONeal BillyONeal added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Sep 8, 2021
BillyONeal
BillyONeal approved these changes Sep 13, 2021
View reviewed changes
@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 13, 2021
@BillyONeal BillyONeal merged commit e571da5 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Member

BillyONeal commented Sep 14, 2021

Thanks for the fix and sorry for the runaround :)

@Osyotr Osyotr deleted the netcdf_c_linux_dynamic branch September 14, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

+2 more reviewers

@dg0yt dg0yt dg0yt left review comments

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Osyotr @BillyONeal @dg0yt @JonLiu1993