Fix c-ares compilation under Linux with dynamic linkage#19126
Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom Aug 2, 2021
Merged
Fix c-ares compilation under Linux with dynamic linkage#19126dan-shaw merged 3 commits intomicrosoft:masterfrom
dan-shaw merged 3 commits intomicrosoft:masterfrom
Conversation
Contributor
|
I can't repro this issue, did you use the official triplet |
Contributor
Author
|
Checked out latest master today, changed to dynamic linkage in the default x64-linux triplet (VCPKG_LIBRARY_LINKAGE dynamic) and then just ran vcpkg install c-ares:x64-linux. With shared linkage in the title, I meant dynamic linkage. Updated the title. |
JackBoosY
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Without the changes in this PR, the Linux build fails under dynamic linkage with the following error:
Which triplets are supported/not supported? Have you updated the CI baseline?
Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes