Skip to content

Fix c-ares compilation under Linux with dynamic linkage#19126

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
ahojnnes:user/joschonb/c-ares-linux-shared
Aug 2, 2021
Merged

Fix c-ares compilation under Linux with dynamic linkage#19126
dan-shaw merged 3 commits intomicrosoft:masterfrom
ahojnnes:user/joschonb/c-ares-linux-shared

Conversation

@ahojnnes
Copy link
Contributor

Describe the pull request

Without the changes in this PR, the Linux build fails under dynamic linkage with the following error:

Building package c-ares[core]:x64-linux...
-- Downloading https://github.com/c-ares/c-ares/archive/cares-1_17_1.tar.gz -> c-ares-c-ares-cares-1_17_1.tar.gz...
-- Extracting source .../downloads/c-ares-c-ares-cares-1_17_1.tar.gz
-- Using source at .../buildtrees/c-ares/src/res-1_17_1-7723edf4cb.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: .../packages/c-ares_x64-linux/share/c-ares/copyright
-- Performing post-build validation
There should be no empty directories in .../packages/c-ares_x64-linux
The following empty directories were found:
  • Which triplets are supported/not supported? Have you updated the CI baseline?

Yes

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@JackBoosY
Copy link
Contributor

JackBoosY commented Jul 26, 2021

I can't repro this issue, did you use the official triplet x64-linux?
And can you please provide the install log buildtrees/c-ares/install-x64-linux-dbg-out.log ?

@JackBoosY JackBoosY added requires:more-information This Issue requires more information to solve requires:author-response category:port-bug The issue is with a library, which is something the port should already support and removed requires:more-information This Issue requires more information to solve labels Jul 26, 2021
@ahojnnes
Copy link
Contributor Author

Checked out latest master today, changed to dynamic linkage in the default x64-linux triplet (VCPKG_LIBRARY_LINKAGE dynamic) and then just ran vcpkg install c-ares:x64-linux. With shared linkage in the title, I meant dynamic linkage. Updated the title.

@ahojnnes ahojnnes changed the title Fix c-ares compilation under Linux with shared linkage Fix c-ares compilation under Linux with dynamic linkage Jul 26, 2021
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jul 27, 2021
@dan-shaw dan-shaw merged commit 9db6c29 into microsoft:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants