Skip to content

[kf5bookmarks] new port#19780

Merged
BillyONeal merged 20 commits intomicrosoft:masterfrom
wrobelda:kf5bookmarks
Sep 28, 2021
Merged

[kf5bookmarks] new port#19780
BillyONeal merged 20 commits intomicrosoft:masterfrom
wrobelda:kf5bookmarks

Conversation

@wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Aug 28, 2021

Describe the pull request
Adds new kf5bookmarks port.
Depends on:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 11c16cd..2868530 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index dd7b832..6ed8d32 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 98c520d..6897fb8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

@wrobelda wrobelda mentioned this pull request Aug 28, 2021
5 tasks
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 30, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout de623488c7d9ab90328ec447f241dfff172b1c45 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 667255b..c733749 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 26, 2021
@NancyLi1013
Copy link
Contributor

LGTM now. thanks for adding this port. @wrobelda

@BillyONeal BillyONeal merged commit 6bbee1c into microsoft:master Sep 28, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants