[kf5kio] new port by wrobelda · Pull Request #19779 · microsoft/vcpkg

wrobelda · 2021-08-28T12:25:39Z

Describe the pull request
Adds new kf5kio port.
Depends on following ports:

[kf5textwidgets] new port #19766
[kf5service] new port #19180
[kf5bookmarks] new port #19780
[kf5solid] Fix CMake config; some extra fixes #19810
[kf5notifications] new port #19828
Which triplets are supported/not supported? Have you updated the CI baseline?

All official plus arm64-osx
Does your PR follow the maintainer guide?

Yes.
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 2c5a139..1d6df47 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.75.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1
@@ -2952,6 +2956,10 @@
       "baseline": "5.84.0",
       "port-version": 0
     },
+    "kf5kio": {
+      "baseline": "5.75.0",
+      "port-version": 0
+    },
     "kf5plotting": {
       "baseline": "5.84.0",
       "port-version": 1
@@ -2959,7 +2967,7 @@
     "kf5service": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5solid": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9d34a3d..1d6df47 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.75.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9d34a3d..1d6df47 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.75.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9d34a3d..1d6df47 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.75.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9d34a3d..b2a0138 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5bookmarks": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5codecs": {
       "baseline": "5.84.0",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 03527e4..b2a0138 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2967,7 +2967,7 @@
     "kf5service": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5solid": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 03527e4..b2a0138 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2967,7 +2967,7 @@
     "kf5service": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5solid": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 03527e4..b2a0138 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2967,7 +2967,7 @@
     "kf5service": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5solid": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout de623488c7d9ab90328ec447f241dfff172b1c45 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index ed76e99..94084ad 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2967,7 +2967,7 @@
     "kf5service": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5solid": {
       "baseline": "5.84.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout de623488c7d9ab90328ec447f241dfff172b1c45 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index ed76e99..94084ad 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2967,7 +2967,7 @@
     "kf5service": {
       "baseline": "5.84.0",
       "port-version": 0
-    },    
+    },
     "kf5solid": {
       "baseline": "5.84.0",
       "port-version": 0

wrobelda · 2021-09-29T15:40:20Z

@JackBoosY all the dependencies are now in master, ready to merge.

wrobelda · 2021-10-04T10:29:41Z

@JackBoosY can this be merged already?

wrobelda · 2021-10-06T17:53:03Z

@JonLiu1993 is there anything that's left to be done here? It is a blocker for a bunch of other PRs of mine, hence me pinging.

JackBoosY · 2021-10-08T01:39:46Z

We got back from our vacations, sorry for late.

JonLiu1993 · 2021-10-08T01:51:29Z

@wrobelda ,I am testing feature locally,sorry for late.

versions/k-/kf5kio.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

JonLiu1993 · 2021-10-08T09:37:33Z

All feature are tested successfully in the following triplet :

x86-windows
x64-windows
x64-windows-static

BillyONeal · 2021-10-11T17:17:19Z

Thanks for the new port :)

github-actions bot requested changes Aug 28, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from f9084b3 to b32ec75 Compare August 28, 2021 12:50

github-actions bot requested changes Aug 28, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from b32ec75 to 1935bdb Compare August 28, 2021 13:05

github-actions bot requested changes Aug 28, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from 1935bdb to 2a265da Compare August 28, 2021 13:11

github-actions bot requested changes Aug 28, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from 2a265da to 39ef9fc Compare August 28, 2021 16:11

github-actions bot requested changes Aug 28, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from 39ef9fc to 89531c1 Compare August 28, 2021 16:40

github-actions bot requested changes Aug 28, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from 89531c1 to 2d8b888 Compare August 28, 2021 18:14

github-actions bot requested changes Aug 28, 2021

View reviewed changes

PhoebeHui assigned JonLiu1993 Aug 30, 2021

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 30, 2021

wrobelda force-pushed the kf5kio branch from 2d8b888 to a093623 Compare August 30, 2021 14:51

github-actions bot requested changes Aug 30, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from ecd7219 to 4cd00be Compare August 30, 2021 15:02

github-actions bot approved these changes Aug 30, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from 4cd00be to a292220 Compare August 30, 2021 19:07

github-actions bot approved these changes Aug 30, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch 2 times, most recently from bc90758 to 5b424cd Compare August 30, 2021 20:16

github-actions bot approved these changes Aug 30, 2021

View reviewed changes

wrobelda force-pushed the kf5kio branch from 5b424cd to c956c64 Compare August 30, 2021 20:20

github-actions bot approved these changes Aug 30, 2021

View reviewed changes

wrobelda added 7 commits September 29, 2021 18:39

[kf5kio] add kf5wallet feature

1acde3e

[kf5kio] update versions

c66c895

[kf5kio] knotifications is non-Windows and non-Android

86b36ef

[kf5kio] update versions

44c165c

[kf5io] re-enable parallel configure

cb4361c

[kf5io] use generic, non-semver versioning

0a84d77

[kf5kio] update versions

ffd7a3b

wrobelda force-pushed the kf5kio branch from 1247078 to ffd7a3b Compare September 29, 2021 15:39

github-actions bot approved these changes Sep 29, 2021

View reviewed changes

JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 30, 2021

JackBoosY requested a review from JonLiu1993 September 30, 2021 02:25

JackBoosY approved these changes Sep 30, 2021

View reviewed changes

JonLiu1993 approved these changes Oct 8, 2021

View reviewed changes

JonLiu1993 suggested changes Oct 8, 2021

View reviewed changes

versions/k-/kf5kio.json Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Oct 8, 2021

[kf5kio] remove the 5.75 version info

75cac62

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot approved these changes Oct 8, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Oct 8, 2021

JonLiu1993 removed the requires:all-feature-testing label Oct 8, 2021

JonLiu1993 approved these changes Oct 8, 2021

View reviewed changes

JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 9, 2021

BillyONeal merged commit 6ff166c into microsoft:master Oct 11, 2021

wrobelda deleted the kf5kio branch October 12, 2021 07:01

Conversation

wrobelda commented Aug 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

wrobelda commented Sep 29, 2021

Uh oh!

wrobelda commented Oct 4, 2021

Uh oh!

wrobelda commented Oct 6, 2021

Uh oh!

JackBoosY commented Oct 8, 2021

Uh oh!

JonLiu1993 commented Oct 8, 2021

Uh oh!

Uh oh!

JonLiu1993 commented Oct 8, 2021

Uh oh!

BillyONeal commented Oct 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wrobelda commented Aug 28, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?