[vamp-sdk] update to 2.10; switch download URL to GitHub; fix path of installed headers#19572
Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom Aug 19, 2021
Merged
[vamp-sdk] update to 2.10; switch download URL to GitHub; fix path of installed headers#19572dan-shaw merged 2 commits intomicrosoft:masterfrom
dan-shaw merged 2 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This works around a bad SSL certificate on https://code.soundsoftware.ac.uk : Error: Failed to download from mirror set: https://code.soundsoftware.ac.uk/attachments/download/2589/vamp-plugin-sdk-2.9.0.zip: % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (60) SSL certificate problem: unable to get local issuer certificate More details here: https://curl.se/docs/sslcerts.html curl failed to verify the legitimacy of the server and therefore could not establish a secure connection to it. To learn more about this situation and how to fix it, please visit the web page mentioned above.
Contributor
Author
|
x64-windows-static failure seems unrelated? Azure Pipelines says there is a regression in colmap:x64-windows-static... |
Contributor
This is unrelated. It happened to another PR already: #19551. |
Merged
Contributor
|
This GitHub repo (c4dm/vamp-plugin-sdk) looks official enough to me to depend upon -- it is from an organization that the primary author (@cannam) is in. |
Contributor
Author
|
I trust GitHub to keep their SSL certificate valid more than the website for this package. |
These are the paths installed by the vamp-plugin-sdk-devel Fedora package: /usr/include/vamp /usr/include/vamp-hostsdk /usr/include/vamp-hostsdk/Plugin.h /usr/include/vamp-hostsdk/PluginBase.h /usr/include/vamp-hostsdk/PluginBufferingAdapter.h /usr/include/vamp-hostsdk/PluginChannelAdapter.h /usr/include/vamp-hostsdk/PluginHostAdapter.h /usr/include/vamp-hostsdk/PluginInputDomainAdapter.h /usr/include/vamp-hostsdk/PluginLoader.h /usr/include/vamp-hostsdk/PluginSummarisingAdapter.h /usr/include/vamp-hostsdk/PluginWrapper.h /usr/include/vamp-hostsdk/RealTime.h /usr/include/vamp-hostsdk/host-c.h /usr/include/vamp-hostsdk/hostguard.h /usr/include/vamp-hostsdk/vamp-hostsdk.h /usr/include/vamp-sdk /usr/include/vamp-sdk/FFT.h /usr/include/vamp-sdk/Plugin.h /usr/include/vamp-sdk/PluginAdapter.h /usr/include/vamp-sdk/PluginBase.h /usr/include/vamp-sdk/RealTime.h /usr/include/vamp-sdk/plugguard.h /usr/include/vamp-sdk/vamp-sdk.h /usr/include/vamp/vamp.h
PhoebeHui
added
the
category:port-update
PhoebeHui
added
the
info:needs-maintainer-attention
Be-ing
changed the title
|
It's after the fact I know, but I just want to agree that this is the right thing to do. There have been ongoing problems with the previous server, and the Github repo is equally "official". |
Be-ing
added a commit
to tenacityteam/vcpkg
that referenced
this pull request
Aug 19, 2021
microsoft#19572 was merged.
5 tasks
n0toose
pushed a commit
to Be-ing/tenacity
that referenced
this pull request
Aug 22, 2021
vamp-sdk has been removed from the overlay since microsoft/vcpkg#19572 was merged upstream. Signed-off-by: Be <be@mixxx.org>
emabrey
pushed a commit
to tenacityteam/vcpkg
that referenced
this pull request
Sep 28, 2021
microsoft#19572 was merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around a bad SSL certificate on
https://code.soundsoftware.ac.uk :
Error: Failed to download from mirror set:
https://code.soundsoftware.ac.uk/attachments/download/2589/vamp-plugin-sdk-2.9.0.zip: % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html
curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
Describe the pull request
What does your PR fix?
Fixed outdated port and works around bad SSL certificate
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes