[vcpkg baseline][vcpkg_configure_make] Pass make tool to `vcpkg_build_make` by dg0yt · Pull Request #19361 · microsoft/vcpkg

dg0yt · 2021-08-04T12:09:56Z

What does your PR fix?

This PR amends [vcpkg_build_make] Always use msys make on win32 host #19164 which could unexpectedly change the make tool location to a second MSYS root, acquired in vcpkg_build_make, in addition to the one created in vcpkg_configure_make. The usage of different MSYS roots in configure and build will lead to different mapping of POSIX-style paths (/usr/bin etc.), possibly causing strange msys build errors such as [gettext] build failure #19337 (gettext).

With this PR, the make tool is discovered and set as part of vcpkg_configure_make. When vcpkg_build_make is used together with vcpkg_configure_make, it no longer needs to acquire an MSYS root. However, this capability is left for compatibility with portfile which do not use vcpkg_configure_make.
Which triplets are supported/not supported? Have you updated the CI baseline?

All, no.
~~Note that apart from changes for windows (MSYS2), there is also a change for other systems, merging the previous find_program calls for gmake and make.~~
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

No ports changed.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gettext but no changes to version or port version.
-- Version: 0.21#4
-- Old SHA: b6cde01ab4095a258993eaf85eb31c1e845c64a6
-- New SHA: b3d90d5c4b8c12645cc11ec9cb0c515e96061324
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gettext but no changes to version or port version.
-- Version: 0.21#4
-- Old SHA: b6cde01ab4095a258993eaf85eb31c1e845c64a6
-- New SHA: cb7daf9630824a6fc374cccd33249df5be905381
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Neumann-A · 2021-08-04T12:46:34Z

@dg0yt add [skip ci] to the commit messages to deactivate the github actions spam

dg0yt · 2021-08-04T13:01:23Z

From x64-windows-static, edited for readability:

PATH:
C:/a/2/s/scripts/buildsystems/make_wrapper
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30037\bin\HostX64\x64
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\VC\VCPackages
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin\Roslyn
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Performance Tools\x64
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Performance Tools
C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\\x64
C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\x64
C:\Program Files (x86)\HTML Help Workshop
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\devinit
C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64
C:\Program Files (x86)\Windows Kits\10\bin\x64
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\\MSBuild\Current\Bin
C:\Windows\Microsoft.NET\Framework64\v4.0.30319
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools
C:\Program Files\PowerShell\7
D:/downloads/tools/msys2/703e5aa15d402568/usr/share/automake-1.16
C:/a/2/s/scripts/buildsystems/make_wrapper
D:/downloads/tools/msys2/703e5aa15d402568/usr/bin
C:\Windows\system32
C:\Windows
C:\Windows\system32\Wbem
C:\Windows\system32\WindowsPowerShell\v1.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\Llvm\x64\bin
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerExe
D:/downloads/tools/winflexbison/0a14154bff-a8cf65db07
D:/downloads/tools/ninja/1.10.2-windows
D:/downloads/tools/ninja/1.10.2-windows'

  MAKE before PR 19164:
  'D:/downloads/tools/msys2/703e5aa15d402568/usr/bin/make.exe'

  MAKE after PR 19164:
  'D:/downloads/tools/msys2/aaafe87dcead272e/usr/bin/make.exe'

Facts:

There is a wild mix of \ and / paths.
C:/a/2/s/scripts/buildsystems/make_wrapper is listed twice.
vcpkg_build_make probably acquires a different MSYS_ROOT than vcpkg_configure_make. (I didn't want to touch vcpkg_build_make at this point, in order to limit the number of ports being rebuild.)
This can be a problem when MSYS tries to map between Windows paths and /usr/bin etc.
This can be seen as an argument for vcpkg_build_make to really use the same MSYS_ROOT as vcpkg_configure_make.

CC @JackBoosY

dg0yt · 2021-08-04T14:17:57Z

This can be seen as an argument for vcpkg_build_make to really use the same MSYS_ROOT as vcpkg_configure_make.

The other option is to set MAKE already in vcpkg_configure_make. That's how it is called...

dg0yt · 2021-08-04T16:57:28Z

For discussion: Use a public global VCPKG_MAKE instead of Z_VCPKG_MAKE, and document it?
This would allow to avoid MSYS root acquisition even in portfiles which do not use vcpkg_configure_make, or allow pre-definition in custom triplets.

scripts/cmake/vcpkg_build_make.cmake

dg0yt · 2021-08-05T04:44:36Z

With regard to OpenBSD, this PR would accept make if there is no gmake installed. IIRC this is a different flavour of make which doesn't work for all Makefiles. Maybe the former if branching has to be added again.

JackBoosY · 2021-08-05T07:39:32Z

Can you please merge the starlink-ast part of the code in #19325 to this branch after ci test?

dg0yt · 2021-08-05T07:47:10Z

Can you please merge the starlink-ast part of the code in #19325 to this branch after ci test?

Okay.

I will wait for CI to finish. (It may take some hours. Given that some represenative runs are okay, I might perhaps start earlier?)
I will restore safe BSD gmake lookup, to avoid regressions which are not covered by CI.
I will pick the starlink-ast changes.

JackBoosY · 2021-08-05T09:58:15Z

@dg0yt Please merge starlink-ast changes when x64-windows test finished.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index cf5bb06..81c3a2a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6090,7 +6090,7 @@
     },
     "starlink-ast": {
       "baseline": "9.2.4",
-      "port-version": 0
+      "port-version": 1
     },
     "status-code": {
       "baseline": "1.0.0-ab3cd821",
diff --git a/versions/s-/starlink-ast.json b/versions/s-/starlink-ast.json
index f357f55..a724950 100644
--- a/versions/s-/starlink-ast.json
+++ b/versions/s-/starlink-ast.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "2fecd468269d73b6e8f29a297c4f7db771ea37c4",
+      "version-semver": "9.2.4",
+      "port-version": 1
+    },
     {
       "git-tree": "50f0b71ca66bd9e4ce6cb5a153e25878dd7a0600",
       "version-semver": "9.2.4",

dg0yt · 2021-08-05T18:28:25Z

x64_windows_static: The failing port is tcl, which doesn't use the changed scripts for windows.

D:\buildtrees\tcl\x64-windows-static-rel\win\..\libtommath\bn_s_mp_toom_sqr.c(148): fatal error C1051: program database file, 'D:\buildtrees\tcl\x64-windows-static-rel\win\vc140.pdb', has an obsolete format, delete it and recompile

JackBoosY · 2021-08-06T02:40:04Z

LGTM on my side, ping @dan-shaw for review and merge this PR first.

strega-nil-ms · 2021-08-07T14:48:40Z

Since this fixes the same thing as #19418, and this is a better fix, merging this instead of that.

github-actions bot requested changes Aug 4, 2021

View reviewed changes

dg0yt force-pushed the issue-19337 branch from 911fa35 to d913470 Compare August 4, 2021 12:27

github-actions bot requested changes Aug 4, 2021

View reviewed changes

Pass 'make' between vcpkg scripts

257e8bf

dg0yt force-pushed the issue-19337 branch from d913470 to 257e8bf Compare August 4, 2021 14:59

github-actions bot approved these changes Aug 4, 2021

View reviewed changes

dg0yt changed the title ~~[gettext] Examining build problem (WIP)~~ [vcpkg_configure_make] Pass make tool to vcpkg_build_make Aug 4, 2021

dg0yt mentioned this pull request Aug 4, 2021

[vcpkg baseline][vcpkg-build-make] Use the same MSYS_ROOT in configure and build #19325

Closed

dg0yt marked this pull request as ready for review August 4, 2021 20:46

JonLiu1993 assigned PhoebeHui Aug 5, 2021

JackBoosY self-assigned this Aug 5, 2021

JackBoosY suggested changes Aug 5, 2021

View reviewed changes

scripts/cmake/vcpkg_build_make.cmake Outdated Show resolved Hide resolved

JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 5, 2021

This was linked to issues Aug 5, 2021

[gettext] build failure #19337

Closed

[mpfr] x64-windows build failure #19353

Closed

JackBoosY changed the title ~~[vcpkg_configure_make] Pass make tool to vcpkg_build_make~~ [vcpkg baseline][vcpkg_configure_make] Pass make tool to vcpkg_build_make Aug 5, 2021

JackBoosY added the info:world-rebuild label Aug 5, 2021

PhoebeHui mentioned this pull request Aug 5, 2021

[vcpkg-cmake] Fix vcpkg_copy_pdbs false alarm #19369

Merged

dg0yt and others added 2 commits August 5, 2021 13:54

Restore original BSD gmake lookup

d93b815

[starlink-ast] Add ADDITIONAL_MSYS_PACKAGES to vcpkg_configure_make

919801d

github-actions bot requested changes Aug 5, 2021

View reviewed changes

[starlink-ast] x-add-version

27d772f

github-actions bot approved these changes Aug 5, 2021

View reviewed changes

JackBoosY approved these changes Aug 6, 2021

View reviewed changes

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 6, 2021

kcgen mentioned this pull request Aug 6, 2021

Use vcpkg from its repository dosbox-staging/dosbox-staging#1175

Merged

JonLiu1993 mentioned this pull request Aug 6, 2021

[mpfr] build failure #19394

Closed

JackBoosY mentioned this pull request Aug 6, 2021

[cmake] Update to 3.21.1 #18955

Merged

cenit mentioned this pull request Aug 6, 2021

Revert "Always use msys make on win32 host (#19164)" #19418

Closed

strega-nil-ms merged commit 57bd710 into microsoft:master Aug 7, 2021

cenit mentioned this pull request Aug 8, 2021

[gettext:x64-windows] build failure #19411

Closed

NancyLi1013 mentioned this pull request Aug 9, 2021

[libmagic:x64-windows] Build failure due to "libtool could not find a file being linked against!" #19417

Closed

JackBoosY mentioned this pull request Aug 9, 2021

[fontconfig] build failure on windows 10 #19419

Closed

kcgen mentioned this pull request Aug 14, 2021

Resume using GitHub's built-in vcpkg instead of work-around from repo dosbox-staging/dosbox-staging#1201

Merged

dg0yt deleted the issue-19337 branch September 5, 2021 05:19

Conversation

dg0yt commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Neumann-A commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Aug 4, 2021

Uh oh!

dg0yt commented Aug 4, 2021

Uh oh!

dg0yt commented Aug 4, 2021

Uh oh!

Uh oh!

dg0yt commented Aug 5, 2021

Uh oh!

JackBoosY commented Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Aug 5, 2021

Uh oh!

JackBoosY commented Aug 5, 2021

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dg0yt commented Aug 5, 2021

Uh oh!

JackBoosY commented Aug 6, 2021

Uh oh!

strega-nil-ms commented Aug 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dg0yt commented Aug 4, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

Neumann-A commented Aug 4, 2021 •

edited

Loading

JackBoosY commented Aug 5, 2021 •

edited

Loading