[vcpkg_build_make] Always use msys make on win32 host#19164
Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom Aug 2, 2021
Merged
[vcpkg_build_make] Always use msys make on win32 host#19164dan-shaw merged 1 commit intomicrosoft:masterfrom
dan-shaw merged 1 commit intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NancyLi1013
added
the
category:tool-update
NancyLi1013
changed the title
NancyLi1013
approved these changes
Jul 27, 2021
ras0219-msft
approved these changes
Jul 27, 2021
Contributor
|
why not adding no_default_paths too? |
Contributor
Author
|
@cenit You are right, I meant to add this too. |
NancyLi1013
added
the
info:needs-maintainer-attention
This was referenced Aug 4, 2021
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Aug 6, 2021
This reverts commit 7793524.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
This PR ensures that
cmake_build_makeuses themakeprogram it acquires via msys, instead of allowing an instance of make which is earlier in the path, e.g. side by side with the compiler.Fixes issues like [libiconv:x64-mingw-dynamic] build failure #19117, hopefully (mingw32-make invoked as make with mingw32-w64 toolchain from Chocolatey.)
Which triplets are supported/not supported? Have you updated the CI baseline?
all (changing behaviour for windows hosts), no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?not needed