[shaderc] Add fix for installing shaderc_util#18979
Merged
vicroms merged 2 commits intomicrosoft:masterfrom Jul 23, 2021
Merged
[shaderc] Add fix for installing shaderc_util#18979vicroms merged 2 commits intomicrosoft:masterfrom
vicroms merged 2 commits intomicrosoft:masterfrom
Conversation
NancyLi1013
added
the
category:port-feature
NancyLi1013
suggested changes
Jul 19, 2021
NancyLi1013
approved these changes
Jul 23, 2021
NancyLi1013
added
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
The current version of the port shaderc neither installs shaderc_combined nor shaderc_shared, which both combine the targets shaderc and shaderc_util. Currently, only shaderc is installed by the port. However, if a program uses functionality from shaderc_util, there is currently no way to link to it. Thus, this PR adds shaderc_util as an installation target.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.