[shaderc] Re-fix installation

[JackBoosY]

• Enable dynamic build and re-fix the dependency relationship.
• Remove the util installation patch since we don't need it (added in [shaderc] Add fix for installing shaderc_util #18979).
• Disable build sample.
• Re-factory portfile.cmake.

Related: #16137.

[JackBoosY]

@jmoguillansky-gpsw Can you please test this PR?

Thanks.

[NancyLi1013]

Related issue #16658

[ras0219-msft]

Please see #16137 (comment)

[jmoguillansky-gpsw]

@jmoguillansky-gpsw Can you please test this PR?

Thanks.

Hi @JackBoosY I tested your branch, I was able to build shaderc shared lib successfully.
Thanks, much appreciated!

[JackBoosY]

@ras0219-msft glslang and spir-tools use some symbols that are not exported in shaderc, so if we need to build them, we must first build static shaderc.

[ras0219-msft]

glslang and spir-tools use some symbols that are not exported in shaderc

shaderc depends on glslang and spirv-tools; therefore they cannot be depending on symbols exported by shaderc:

# ports/control/shaderc

Build-Depends: glslang, spirv-tools

Therefore, if glslang and spirv-tools can only be built statically, shaderc should also be built statically. Dynamic libraries should (generally) not depend on static libraries.

[jmoguillansky-gpsw]

glslang and spir-tools use some symbols that are not exported in shaderc

shaderc depends on glslang and spirv-tools; therefore they cannot be depending on symbols exported by shaderc:

# ports/control/shaderc

Build-Depends: glslang, spirv-tools

Therefore, if glslang and spirv-tools can only be built statically, shaderc should also be built statically. Dynamic libraries should (generally) not depend on static libraries.

I don't think shaderc links against glslang or spriv-tools.
I think it includes a binary executable, glslc, which uses glslang and spirv-tools.
See the README: https://github.com/google/shaderc

[DatCaptainHorse]

Any updates on this? Would love to use shaderc thru vcpkg as it has issues with path size limits in my project.

[JackBoosY]

@CaptainHorse Will continue to handle this PR later.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 1257354a3ab0bebd8abe95281ca561537853578c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/shaderc.json b/versions/s-/shaderc.json
index ce2fa76..2f2112f 100644
--- a/versions/s-/shaderc.json
+++ b/versions/s-/shaderc.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "acddbab84ab19cc4d1e04ecb5277d3969cf9b093",
+      "git-tree": "f6a82ca83afbf20c08d6d001f133cd5fd2672108",
       "version": "2021.1",
       "port-version": 2
     },

[JackBoosY]

Requires #19219.

[JackBoosY]

Linux regression related to KhronosGroup/SPIRV-Tools#1569.

[PhoebeHui]

The related upstream issue on linux has been fixed, please reopen and continue this PR if you have time.