Skip to content

[Mapnik] new port#18849

Merged
BillyONeal merged 50 commits intomicrosoft:masterfrom
mathisloge:mapnik-two
Sep 16, 2021
Merged

[Mapnik] new port#18849
BillyONeal merged 50 commits intomicrosoft:masterfrom
mathisloge:mapnik-two

Conversation

@mathisloge
Copy link
Contributor

@mathisloge mathisloge commented Jul 7, 2021

Describe the pull request
adds mapnik without forking the mapnik repository. However, this PR needs the current master.

Adds the mapbox-geometry and mapbox-polyline ports. (added in #16838).

todo

@JonLiu1993 JonLiu1993 self-assigned this Jul 7, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 7, 2021
@NancyLi1013 NancyLi1013 added the depends:upstream-changes Waiting on a change to the upstream project label Jul 8, 2021
@JonLiu1993
Copy link
Contributor

@mathisloge ,If this pr is ready for review, please turn to open state

@mathisloge
Copy link
Contributor Author

@mathisloge ,If this pr is ready for review, please turn to open state

Yes. Might take some time until upstream gets merged.

@mathisloge
Copy link
Contributor Author

mathisloge commented Sep 14, 2021

standalone mapnik demo which tests the most common functionalities

  • plugin loading
  • file reading
  • map rendering with fonts

https://github.com/mathisloge/mapnik-vcpkg-test

@mathisloge
Copy link
Contributor Author

mathisloge commented Sep 15, 2021

updated to latest commit. It adds mapnik::core as a public dependency of mapnik::mapnik. Changed the usage a bit

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

Sorry for the CI failures, we backed out the check that caused everything to fail for the last 10 hours or so

@dg0yt
Copy link
Contributor

dg0yt commented Sep 16, 2021

@mathisloge For a more convenient CI trigger:

git commit --allow-empty -m "[skip actions] Trigger CI"
git push

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 16, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your efforts. It's has taken so long time on this port. @mathisloge

@mathisloge
Copy link
Contributor Author

@NancyLi1013 thanks for your reviews!
It was indeed a very long time but it has also contributed a lot to upstream (windows support and a far easier setup to build upstream itself)

@BillyONeal BillyONeal merged commit c26101d into microsoft:master Sep 16, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Port Request] <Mapnik>

6 participants