[Mapnik] new port by mathisloge · Pull Request #14628 · microsoft/vcpkg

mathisloge · 2020-11-18T10:49:15Z

Describe the pull request
adds mapnik without forking the mapnik repository. However, this PR needs the current master.

Adds the mapbox-geometry and mapbox-polyline ports. Mapnik is dependend on specific commits, therefore the REF commit.
I'll test with current releases after I've validated mapnik.

What does your PR fix?
Fixes [New Port Request] <Mapnik> #7526
Forked from [MAPNIK] new port added #11656
Which triplets are supported/not supported? Have you updated the CI baseline?
needs CI test
Does your PR follow the maintainer guide? yes

todo

update REPO and REF to mapnik repo when upstream was merged
wait for CMake build support mapnik/mapnik#4191 to be merged

mathisloge · 2020-11-18T11:28:20Z

~~osx and linux fails due to boost-regex build...~~

mathisloge · 2020-11-18T12:23:01Z

added issue mapnik/mapnik#4187 to fix the applied patches csv and geojson

EDIT:
was fixed with mapnik/mapnik@3ae38bb
moving the REF up to remove the patches

mathisloge · 2020-11-18T14:11:52Z

~~Have tested with the viewer example. Ready for review~~

needs to install cmake targets

mathisloge · 2020-11-18T18:10:02Z

so, now it is ready to review. I've compiled a test program to validate that everything compiles

but i still need to fix the static version. somehow the defines got messed up and still i prefixes classes with dllimport..
~~Can someone help me with that?~~

EDIT:
accidentally used an old version for the diff and it is therefore not adjusted correctly.

mathisloge · 2020-11-18T19:10:33Z

Might be good to switch to scons with vcpkg_find_acquire_program/vcpkg_execute_required_process
EDIT:
tried it a bit (https://github.com/mathisloge/vcpkg/tree/mapnik_scons) but i don't really know how this should build since the variables are not correctly taken.

ports/mapnik/vcpkg.json

ports/mapbox-geometry/portfile.cmake

ports/mapbox-polylabel/portfile.cmake

ports/mapnik/cmake/plugins/input/geobuf/CMakeLists.txt

ports/mapnik/cmake/utils/mapnik-render/CMakeLists.txt

ports/mapnik/portfile.cmake

mathisloge · 2020-11-19T10:52:34Z

mhm linux fails due to qt5-location error. but mapnik was build successfully.

NancyLi1013 · 2020-11-20T07:40:06Z

/azp run

azure-pipelines · 2020-11-20T07:40:16Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-11-20T07:46:32Z

@mathisloge

Would you like to add these CMakeLists.txt for mapnik to upstream? I noticed that there are several files in this PR.

mathisloge · 2020-11-20T09:25:19Z

@NancyLi1013 to upstream vcpkg master yes.
Normally mapnik uses scons as a build system but I don't get it to work with vcpkg since all the dependencies would not be correctly noticed by the build system.
I've set the include dirs manually .

Because of that I would like to use cmake as the build system. (URL of scons port https://github.com/mathisloge/vcpkg/tree/mapnik_scons ) note: it is quite messed up because I've tried a few different things

NancyLi1013 · 2020-11-20T10:04:40Z

@NancyLi1013 to upstream vcpkg master yes.

I mean upstream is https://github.com/mapnik/mapnik.

mathisloge · 2020-11-20T10:40:11Z

@NancyLi1013 i don't think that they want to add cmake to their build system. But I will ask them.

mathisloge · 2020-11-20T17:05:11Z

@NancyLi1013 Well, I guess I was wrong. :D
I will create a PR in mapnik to add CMake support. I will convert this PR into a draft.

mathisloge · 2020-11-20T20:18:48Z

PR located at mapnik/mapnik#4191

NancyLi1013 · 2020-12-04T09:00:06Z

/azp run

Add a missing, but required task for Azure DevOps Pipelines, to automatically authenticate against the Artifacts registry. This should help any vcpkg newcomer to integrate easily.

* [sdl2-mixer] Add fluidsynth feature * [sdl2-mixer] Add fluidsynth feature * [sdl2-mixer] Add fluidsynth feature * Updated versions & fixed style * Fixed version hash

* [paho-mqtt] update to 1.3.9 * update version * revert patch format * update version

* update qt to 6.1.2 * version stuff

* [ffmpeg] do not pull in postproc for LGPL build * [ffmpeg] disable avisynthplus on static builds (as it is not functional) * [ffmpeg] bump port version * [ffmpeg] x-add-version

* [exiv2] update to 0.27.4 * update version

Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>

* Fix Irrlicht compilation on OSX * Update port description * Update portfile instructions * Update version * Fix patch files * Add missing cmake dependencies * Remove obsolete comment * Update version * Remove OBJCXX language from project definition to prevent Windows builds from failing * Update versions * Code review tweaks * Update version * Update versions/i-/irrlicht.json Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com> * Fix qt5-3d build failure on OSX * Update qt5-3d version * Update port-version for qt5-3d * Update version for qt5-3d * [qt5-3d] Revert modification to previous version entry Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com> Co-authored-by: Robert Schumacher <ras0219@outlook.com>

* add wagyu * add versions * update hash * update versions

* [ftxui] Add new port (fix #16327) * [ftxui] x-add-version ftxui * [ftxui] Drop UWP support * [ftxui] Update to 2021-06-16 * [ftxui] Overwrite version * [ftxui] Try to fix linux and macOS build * [ftxui] Overwrite version * [ftxui] Fail fast on UWP * [ftxui] Clean version file * [ftxui] Overwrite version * [ftxui] Update to 2021-06-17 * [ftxui] Overwrite version * [ftxui] Remove debug/share * [ftxui] Overwrite version * [ftxui] Quote paths * [ftxui] Overwrite version

* add port: xlsxio * vcpkg x-add-version xlsxio * fix deps * add vcpkg_fixup_pkgconfig() * Apply suggestions from code review To be consistent, `OUT_FEATURE_OPTIONS FEATURE_OPTIONS` in a new line, as in `vcpkg_from_git`. Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * Update ports/xlsxio/portfile.cmake Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * format * use date as version string * vcpkg format-manifest * Update ports/xlsxio/portfile.cmake Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * patch for dependency * fix typo * vcpkg x-add-version * remove feature wide * Update ports/xlsxio/vcpkg.json deprecate libzip that's an alternative and imperfect Co-authored-by: Robert Schumacher <roschuma@microsoft.com> * Update ports/xlsxio/vcpkg.json Co-authored-by: Robert Schumacher <roschuma@microsoft.com> * Update versions/x-/xlsxio.json Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * Remove x64-windows-cpp17 community triplet Co-authored-by: abc <a@b.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

…ing used (#18529) * Fix boost build toolchain options not being used The issue was due to the options only being set for the gcc toolchain, and then only for a specific version. On platforms defaulting to a different toolchain (e.g. macOS) this didn't work at all. Additionally, some missing flags were not propagated, in particular the CMAKE_OSX_DEPLOYMENT_TARGET, CMAKE_OSX_SYSROOT and CMAKE_OSX_ARCHITECTURES * [boost-modular-build-helper] Apply CR comments Co-authored-by: Martijn Otto <git@martijnotto.nl> Co-authored-by: Robert Schumacher <ras0219@outlook.com>

Co-authored-by: Cédric Tabin <cedric.tabin@gmail.com>

mathisloge · 2021-07-06T21:38:14Z

@NancyLi1013 i think i have screwed this PR up. Don't know what has happend here to the git history. :D

Should i open a new fresh PR?

mathisloge · 2021-07-07T08:57:10Z

closed in favor of #18849

NancyLi1013 · 2021-07-08T06:45:28Z

Thanks for your information. Seems your branch is based on upstream master. These changes should be in vcpkg master branch.

mathisloge changed the title ~~[Mapnik]~~ [Mapnik] new port Nov 18, 2020

mathisloge marked this pull request as ready for review November 18, 2020 13:44

mathisloge marked this pull request as draft November 18, 2020 14:24

mathisloge marked this pull request as ready for review November 18, 2020 18:10

mathisloge marked this pull request as draft November 18, 2020 19:10

NancyLi1013 self-assigned this Nov 19, 2020

NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 19, 2020

NancyLi1013 suggested changes Nov 19, 2020

View reviewed changes

NancyLi1013 added the requires:author-response label Nov 19, 2020

mathisloge marked this pull request as ready for review November 19, 2020 10:40

mathisloge requested a review from NancyLi1013 November 19, 2020 10:48

mathisloge mentioned this pull request Nov 20, 2020

Cmake build support mapnik/mapnik#4190

Closed

mathisloge marked this pull request as draft November 20, 2020 17:05

NancyLi1013 added the depends:upstream-changes Waiting on a change to the upstream project label Nov 23, 2020

mathisloge mentioned this pull request Nov 25, 2020

CMake build support mapnik/mapnik#4191

Merged

15 tasks

julianxhokaxhiu and others added 23 commits July 6, 2021 13:37

[binarycaching.md] Improve Azure DevOps example (#18807)

6e770ae

Add a missing, but required task for Azure DevOps Pipelines, to automatically authenticate against the Artifacts registry. This should help any vcpkg newcomer to integrate easily.

[sdl2-mixer] Add fluidsynth feature (#18826)

85a0c69

* [sdl2-mixer] Add fluidsynth feature * [sdl2-mixer] Add fluidsynth feature * [sdl2-mixer] Add fluidsynth feature * Updated versions & fixed style * Fixed version hash

[paho-mqtt] update to 1.3.9 (#18765)

aa174a4

* [paho-mqtt] update to 1.3.9 * update version * revert patch format * update version

[Qt6] Update to 6.1.2 (#18787)

4ef7e72

* update qt to 6.1.2 * version stuff

[ffmpeg] fix LGPL build, disable avisynthplus on static builds (#18803)

7219223

* [ffmpeg] do not pull in postproc for LGPL build * [ffmpeg] disable avisynthplus on static builds (as it is not functional) * [ffmpeg] bump port version * [ffmpeg] x-add-version

[google-cloud-cpp] update to latest release (v1.29.0) (#18759)

fa218ff

[exiv2] update to 0.27.4 (#18750)

4f69281

* [exiv2] update to 0.27.4 * update version

[crow] update to v0.3+1 (#18706)

32d6fb4

Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>

update to latest ref. Hopefully fixes osx

53c09c3

update to latest ref. Hopefully fixes osx

61db194

version

df0a9db

version

9c87f1f

[mapbox-wagyu] add new port (#18771)

7f495f0

* add wagyu * add versions * update hash * update versions

[libzippp] Update to 4.1-1.8.0 (#18553)

e4ee25c

Co-authored-by: Cédric Tabin <cedric.tabin@gmail.com>

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapnik

0057d76

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapnik

5cf0d00

fix baseline

4cf45db

fix baseline

ea21d7c

Merge branch 'mapnik' of https://github.com/mathisloge/vcpkg into mapnik

b284276

mathisloge mentioned this pull request Jul 7, 2021

[Mapnik] new port #18849

Merged

2 tasks

mathisloge closed this Jul 7, 2021

mathisloge deleted the mapnik branch September 13, 2021 15:52

mathisloge mentioned this pull request Mar 29, 2022

Make it available as vcpkg package DiligentGraphics/DiligentEngine#40

Open

Conversation

mathisloge commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

todo

Uh oh!

mathisloge commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathisloge commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathisloge commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathisloge commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathisloge commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathisloge commented Nov 19, 2020

Uh oh!

NancyLi1013 commented Nov 20, 2020

Uh oh!

azure-pipelines bot commented Nov 20, 2020

Uh oh!

NancyLi1013 commented Nov 20, 2020

Uh oh!

mathisloge commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Nov 20, 2020

Uh oh!

mathisloge commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathisloge commented Nov 20, 2020

Uh oh!

mathisloge commented Nov 20, 2020

Uh oh!

NancyLi1013 commented Dec 4, 2020

Uh oh!

mathisloge commented Jul 6, 2021

Uh oh!

mathisloge commented Jul 7, 2021

Uh oh!

NancyLi1013 commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

mathisloge commented Nov 18, 2020 •

edited

Loading

mathisloge commented Nov 18, 2020 •

edited

Loading

mathisloge commented Nov 18, 2020 •

edited

Loading

mathisloge commented Nov 18, 2020 •

edited

Loading

mathisloge commented Nov 18, 2020 •

edited

Loading

mathisloge commented Nov 18, 2020 •

edited

Loading

mathisloge commented Nov 20, 2020 •

edited

Loading

mathisloge commented Nov 20, 2020 •

edited

Loading