Skip to content

[vcpkg baseline][realsense2] Fix config issue on osx#18202

Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/realsense2
Jun 3, 2021
Merged

[vcpkg baseline][realsense2] Fix config issue on osx#18202
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/realsense2

Conversation

@PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented May 31, 2021

Related to #18106

Fix the following issue on osx platform:
From https://github.com/IntelRealSense/librealsense/blob/master/CMakeLists.txt#L14, there is no internet connection, so BUILD_WITH_TM2 was disabled. IMPORT_DEPTH_CAM_FW as well.
However, https://github.com/IntelRealSense/librealsense/blob/master/CMake/unix_config.cmake#L38 directly set the BUILD_WITH_TM2 to ON, it overrides the previous checks, and it ignore the IMPORT_DEPTH_CAM_FW check, that cause the error.

Remove it from CMake/unix_config.cmake since it should be in control of the previous checks in CMakeLists.txt.

CMake Warning at CMakeLists.txt:22 (message):
  No internet connection, disabling IMPORT_DEPTH_CAM_FW

CMake Error at src/tm2/CMakeLists.txt:16 (message):
  BUILD_WITH_TM2 requires IMPORT_DEPTH_CAM_FW
Call Stack (most recent call first):
  src/CMakeLists.txt:57 (include)
  CMakeLists.txt:56 (include)

Report an issue realsenseai/librealsense#9124 to Upstream

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels May 31, 2021
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 31, 2021
@JackBoosY
Copy link
Contributor

Ping @strega-nil-ms for merge this PR first.

@strega-nil-ms strega-nil-ms merged commit 668f048 into microsoft:master Jun 3, 2021
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jun 3, 2021
[vcpkg baseline][realsense2] Fix config issue on osx (microsoft#18202)
@PhoebeHui PhoebeHui deleted the dev/Phoebe/realsense2 branch June 17, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants