[vcpkg baseline][realsense2] Fix config issue on osx#18202
Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom Jun 3, 2021
Merged
[vcpkg baseline][realsense2] Fix config issue on osx#18202strega-nil-ms merged 2 commits intomicrosoft:masterfrom
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
Conversation
NancyLi1013
approved these changes
May 31, 2021
Contributor
|
Ping @strega-nil-ms for merge this PR first. |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jun 3, 2021
[vcpkg baseline][realsense2] Fix config issue on osx (microsoft#18202)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #18106
Fix the following issue on osx platform:
From https://github.com/IntelRealSense/librealsense/blob/master/CMakeLists.txt#L14, there is no internet connection, so BUILD_WITH_TM2 was disabled. IMPORT_DEPTH_CAM_FW as well.
However, https://github.com/IntelRealSense/librealsense/blob/master/CMake/unix_config.cmake#L38 directly set the BUILD_WITH_TM2 to ON, it overrides the previous checks, and it ignore the IMPORT_DEPTH_CAM_FW check, that cause the error.
Remove it from CMake/unix_config.cmake since it should be in control of the previous checks in CMakeLists.txt.
Report an issue realsenseai/librealsense#9124 to Upstream