Skip to content

[docs] vcpkg_from_github beast moved to boost-beast#18106

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
pratikpc:patch-2
Jun 4, 2021
Merged

[docs] vcpkg_from_github beast moved to boost-beast#18106
ras0219-msft merged 1 commit intomicrosoft:masterfrom
pratikpc:patch-2

Conversation

@pratikpc
Copy link
Contributor

Describe the pull request

Came across the webpage on vcpkg.io which took me to an empty beast file.
boost-beast has moved from beast to boost-beast

@PhoebeHui PhoebeHui self-assigned this May 25, 2021
@PhoebeHui PhoebeHui added the category:documentation To resolve the issue, documentation will need to be updated label May 25, 2021
@PhoebeHui PhoebeHui changed the title docs: vcpkg_from_github beast moved to boost-beast [docs] vcpkg_from_github beast moved to boost-beast May 25, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@pratikpc
Copy link
Contributor Author

@PhoebeHui any idea why the checks failed?
I was checking the outputs and I can't understand what caused it

@PhoebeHui
Copy link
Contributor

@strega-nil-ms, could you please take a look? the format.diff suggest to update to original change.

format.diff

diff --git a/docs/maintainers/vcpkg_from_github.md b/docs/maintainers/vcpkg_from_github.md
index 27d03008f..c11b2ed16 100644
--- a/docs/maintainers/vcpkg_from_github.md
+++ b/docs/maintainers/vcpkg_from_github.md
@@ -70,7 +70,7 @@ This exports the `VCPKG_HEAD_VERSION` variable during head builds.
 
 * [cpprestsdk](https://github.com/Microsoft/vcpkg/blob/master/ports/cpprestsdk/portfile.cmake)
 * [ms-gsl](https://github.com/Microsoft/vcpkg/blob/master/ports/ms-gsl/portfile.cmake)
-* [boost-beast](https://github.com/Microsoft/vcpkg/blob/master/ports/boost-beast/portfile.cmake)
+* [beast](https://github.com/Microsoft/vcpkg/blob/master/ports/beast/portfile.cmake)
 
 ## Source
 [scripts/cmake/vcpkg\_from\_github.cmake](https://github.com/Microsoft/vcpkg/blob/master/scripts/cmake/vcpkg_from_github.cmake)

@ras0219
Copy link
Contributor

ras0219 commented May 26, 2021

The "source of truth" for documentation is stored in the helper: https://github.com/Microsoft/vcpkg/blob/master/scripts/cmake/vcpkg_from_github.cmake. We generate the .md file from the helper file using https://github.com/microsoft/vcpkg/blob/master/docs/regenerate.ps1.

You can either make the change in both places, or just make the change in the .cmake file an re-run regenerate.ps1

@pratikpc
Copy link
Contributor Author

@ras0219 thanks!

@pratikpc
Copy link
Contributor Author

@ras0219 @PhoebeHui looks like it's done!

The PR failures in Linux and Windows are download failures for ncurses and libsbml respectively.

@PhoebeHui
Copy link
Contributor

PhoebeHui commented May 31, 2021

The failures on realsense2:x64-osx would be addressed by PR #18202. I would rerun the CI test after the PR merged.

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may delay merging this change since it touches vcpkg_from_github.cmake and therefore the package hashes of most packages, but thanks for the PR!

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 4, 2021
@ras0219-msft ras0219-msft merged commit 750c0bd into microsoft:master Jun 4, 2021
@pratikpc pratikpc deleted the patch-2 branch June 7, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:documentation To resolve the issue, documentation will need to be updated info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants