Skip to content

[vcpkg baseline][libtasn1] Fix static build#18116

Merged
strega-nil-ms merged 7 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-baseline-20210526
May 26, 2021
Merged

[vcpkg baseline][libtasn1] Fix static build#18116
strega-nil-ms merged 7 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-baseline-20210526

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 26, 2021 •
edited
Loading

Fix static build on Windows:

   Creating library asn1Parser.lib and object asn1Parser.exp
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_parser2tree referenced in function main
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_parser2array referenced in function main
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_delete_structure referenced in function main
asn1Parser.obj : error LNK2019: unresolved external symbol __imp_asn1_strerror referenced in function main
asn1Parser.exe : fatal error LNK1120: 4 unresolved externals
   Creating library asn1Coding.lib and object asn1Coding.exp
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_parser2tree referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_print_structure referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_create_element referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_delete_structure referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_write_value referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_der_coding referenced in function main
asn1Coding.obj : error LNK2019: unresolved external symbol __imp_asn1_strerror referenced in function main
...

Add ASN1_STATIC to C_FLAGS / CXX_FLAGS because this macro does not exist in the source configuration file.

Related: #16953

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels May 26, 2021
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Closed
dg0yt
dg0yt reviewed May 26, 2021
View reviewed changes
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
This was referenced May 26, 2021
Merged
Merged
@PhoebeHui PhoebeHui added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels May 26, 2021
JackBoosY
JackBoosY commented May 26, 2021
View reviewed changes
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
PhoebeHui
PhoebeHui approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 26, 2021
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
@JackBoosY
Copy link
Contributor Author

JackBoosY commented May 26, 2021

Ping @strega-nil-ms for merge this PR first.

dg0yt
dg0yt reviewed May 26, 2021
View reviewed changes
JackBoosY
JackBoosY commented May 26, 2021
View reviewed changes
JackBoosY
JackBoosY commented May 26, 2021
View reviewed changes
@JackBoosY JackBoosY mentioned this pull request May 26, 2021
Merged
@strega-nil-ms strega-nil-ms merged commit f2f9f79 into microsoft:master May 26, 2021
@wrobelda wrobelda mentioned this pull request May 27, 2021
Open
@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20210526 branch May 27, 2021 01:55
@JackBoosY JackBoosY mentioned this pull request Jun 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+1 more reviewer

@dg0yt dg0yt dg0yt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JackBoosY @dg0yt @PhoebeHui @strega-nil-ms