Merged
Conversation
ras0219
reviewed
May 17, 2021
JonLiu1993
added
the
category:new-port
Contributor
|
@ras0219,Could you help review this pr? |
PhoebeHui
reviewed
May 25, 2021
Contributor
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
The LUASEC_VERSION looks not used.
JackBoosY
suggested changes
May 25, 2021
Contributor
Author
|
Changed as suggested and removed the prefix from the so library. I'm still not clear on how we'd want to handle a possible name collision. I think the same approach should be applied to luasocket, lpeg, luafilesystem - whatever we pick. |
Contributor
Author
|
@JackBoosY any idea why I'm getting those errors "REGRESSION: libtasn1:x64-windows-static. If expected, add libtasn1:x64-windows-static=fail to .\scripts\ci.baseline.txt." - seems to happen every time, and I'm not sure what it has to do with my changes. |
Contributor
|
Waiting for #18116 merge. |
JackBoosY
added
depends:different-pr
Contributor
|
Ready for review now? |
Contributor
Author
|
Yes, thank you. |
JackBoosY
suggested changes
May 31, 2021
JackBoosY
approved these changes
Jun 1, 2021
JackBoosY
added
info:needs-maintainer-attention
Contributor
|
Thanks @TheCycoONE :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds luasec, a lua library for networking over TLS.
https://github.com/brunoos/luasec/
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes