Skip to content

Update proxy failure hint#17761

Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom
reitowo:fix-proxy-error-hint
May 21, 2021
Merged

Update proxy failure hint#17761
dan-shaw merged 5 commits intomicrosoft:masterfrom
reitowo:fix-proxy-error-hint

Conversation

@reitowo
Copy link
Contributor

@reitowo reitowo commented May 10, 2021

Describe the pull request

As the hint is misleading, we should point out some possible causes in the hint.
Also, a bug cause is presented in the hint, and when the (microsoft/vcpkg-tool#77) is merged, another PR will be opened to delete that hint.

@JackBoosY
Copy link
Contributor

Waiting for #17797 merge.

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label May 12, 2021
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label May 12, 2021
@reitowo
Copy link
Contributor Author

reitowo commented May 13, 2021

Kindly reminder: #17797 merged :)

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 13, 2021
@reitowo
Copy link
Contributor Author

reitowo commented May 14, 2021

Although microsoft/vcpkg-tool#77 get merged, the next PR to remove the bug hint will wait for the next vcpkg's version release.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 14, 2021
@dan-shaw dan-shaw merged commit 38a0efb into microsoft:master May 21, 2021
@reitowo reitowo deleted the fix-proxy-error-hint branch January 17, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vcpkg-tool] pr 49 cause proxy no use

4 participants