[grpc][upb] Update to newer versions#17422
Conversation
|
TL;DR; there is code missing in AFAICT, the build problems on To recap: this PR is trying to gRPC to 1.36.4 and The generator for these files cannot be compiled with upb's CMake files: "However there is no support for building the upb compiler or for generating .upb.c/upb.h files. " https://github.com/protocolbuffers/upb/blob/master/cmake/README.md Meanwhile gRPC includes these generated files in its source, e.g.: https://github.com/grpc/grpc/tree/master/src/core/ext/upb-generated/google/protobuf That is, gRPC includes a copy of We may find more success if we used the I created an (incomplete) patch, it does not work, but has fewer missing symbols: PS: I do not understand gRPC's rationale to adopt |
|
Thanks for the description -- that really helped to understand what's going on! Obviously, it would be best if upb was more mature and it was clearer how to generate sources plus where those sources should live, however for now I think the approach I've pushed in 39d2b38 is the best we have available. Essentially, I've added a small static library to grpc's build that builds the checked-in generated files. There is the possibility of these being out-of-sync with the underlying upb library, but until we're able to generate the files ourselves I don't see a better option. Now that we have host dependencies, it wouldn't be too terrible to do the generation in vcpkg if I knew where the original |
This PR rolls together the changes from #15078 and #17151 which each have issues on their own.
What does your PR fix?
Fixes [upb] update to 2020-12-19 #17140