Skip to content

[grpc] update to 1.36.4#15078

Closed
youknowone wants to merge 1 commit intomicrosoft:masterfrom
youknowone:grpc
Closed

[grpc] update to 1.36.4#15078
youknowone wants to merge 1 commit intomicrosoft:masterfrom
youknowone:grpc

Conversation

@youknowone
Copy link
Copy Markdown
Contributor

@youknowone youknowone commented Dec 12, 2020 •
edited
Loading

Simple minor update

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 14, 2020
NancyLi1013
NancyLi1013 reviewed Dec 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the latest version is 1.34.0. Why not update to this version?

@youknowone
Copy link
Copy Markdown
Contributor Author

youknowone commented Dec 15, 2020

I made this while doing other job, so maybe not correctly remembering.
I think 1.34.0 required to fix the vcpkg patches, but I didn't look in it well.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 23, 2020

Sorry for my delay.

Do you have any suggestions or problems for the latest version 1.34.0? @youknowone

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Mar 4, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Mar 4, 2021

@youknowone

Have you tested the feature in this PR?

NancyLi1013
NancyLi1013 suggested changes Mar 5, 2021
View reviewed changes
Comment thread ports/grpc/vcpkg.json Outdated
Comment thread versions/g-/grpc.json Outdated
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Mar 5, 2021

Hi @youknowone

Seems there is new release 1.36.1 for grpc now.
Would you like to update it to the latest release in this PR?

Thanks.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Apr 2, 2021

@youknowone

Could you please address the review suggestions?

@youknowone
Copy link
Copy Markdown
Contributor Author

youknowone commented Apr 2, 2021

Hi, let me adapt the reviews and update it to grpc 1.36.0

@youknowone
Copy link
Copy Markdown
Contributor Author

youknowone commented Apr 2, 2021 •
edited
Loading

I have a question and a request.

1. what should be the value for git-tree in versions/g-/grpc.json?
2. To use vcpkg upb, it must be updated to later than 2020-11-xx. Because it changed its cmake files between the version and the latest version of vcpkg, updating upb is not trivial for me. Could anyone help it?

@youknowone youknowone changed the title [grpc] update to 1.33.2 [grpc] update to 1.36.4 Apr 2, 2021
@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Apr 12, 2021

@youknowone, #17151 would update upb.

@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Apr 12, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@coryan coryan mentioned this pull request Apr 21, 2021
Closed
@ras0219 ras0219 mentioned this pull request Apr 21, 2021
Merged
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Apr 25, 2021

grpc has been updated to 1.36.4 via PR #17422, which has been merged to maser branch.

So this PR is no longer needed now. Thanks for your contribution. @youknowone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@youknowone @NancyLi1013 @PhoebeHui @ras0219-msft @JonLiu1993