Skip to content

[Libtasn1] disable documentation#17420

Merged
ras0219-msft merged 14 commits intomicrosoft:masterfrom
xandox:libtasn1_disable_documentation_pr_15605
Apr 23, 2021
Merged

[Libtasn1] disable documentation#17420
ras0219-msft merged 14 commits intomicrosoft:masterfrom
xandox:libtasn1_disable_documentation_pr_15605

Conversation

@xandox
Copy link
Contributor

@xandox xandox commented Apr 21, 2021

Documentation generates by gtk tool which not must exists. For PR #15605

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    same, No

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@dg0yt
Copy link
Contributor

dg0yt commented Apr 21, 2021

This PR changes options to configure which default to being off anyway AFAIK. We have seen this package fail at least on osx already before configure due to failed attempts to run gtkdocize during autoreconf (#17098). If this PR runs into this problem, too:

I tried to get this solved for CI via provisioning (#17227), and I made other proposals to solve this also for vcpkg users. The last attempt, #17406, doesn't seem to work as well as I thought for other packages, but that approach might perhaps be turned around in the libtasn1's portfile by adding

set(ENV{GTKDOCIZE} true)

before calling vcpkg_configure_make. (I cannot test this at the moment.)

@xandox
Copy link
Contributor Author

xandox commented Apr 21, 2021

gt-html is on by default according to configure --help

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 22, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Apr 22, 2021

There are many changes to formatting. Some are improvements but aren't IMO.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xandox, thanks for the PR!

@xandox
Copy link
Contributor Author

xandox commented Apr 22, 2021

Formatting is fixed. Sorry for that, did not notice my autoformat job.

@xandox xandox requested a review from PhoebeHui April 22, 2021 09:42
@PhoebeHui
Copy link
Contributor

No problem, thanks for your contribution!

@PhoebeHui
Copy link
Contributor

The CI failed due to #17057.

@ras0219-msft ras0219-msft merged commit cc64806 into microsoft:master Apr 23, 2021
@ras0219-msft
Copy link
Contributor

This LGTM, thanks for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants