[many ports] Update KF5 frameworks to 5.81 by wrobelda · Pull Request #17268 · microsoft/vcpkg

wrobelda · 2021-04-13T18:09:22Z

Describe the pull request

Updates KDE Frameworks to 5.81

Which triplets are supported/not supported? Have you updated the CI baseline?

No change

Does your PR follow the maintainer guide?

Yes

wrobelda · 2021-04-13T18:53:23Z

ports/kf5guiaddons/vcpkg.json

If wondering, please see this conversation for details on why this approach.

Conversation is behind a login-gate and cannot be seen.

This points to official #vcpkg channel and the maintainers are there. The conversation linked was with @ras0219-msft and is intended for any other vcpkg maintainer who would be reviewing this PR. If you're not willing to create a Slack account and join that channel, I don't know how to help you, but it can be seen.

Perhaps instead of being rude, you could kindly copy and paste the discussion or a synopsis thereof into the PR for those of us who do not wish to sign up for yet another account(TM).

Yeah, I can't see that and I'm a maintainer; I would really appreciate a copy-paste of it...

oh, I see what it is: default-features can't be platform-expression'd away. This is an issue with default-features, and should be fixed (and until then, we use this workaround).

@strega-nil yes, this is precisely what @ras0219-msft suggested. The upstream added a default dependency on qt5-waylandon Linux (1, 2). I didn’t want to go against the wish of the maintainers, but also qt5-wayland is not stable, per its portfile's memo. As such, I needed to make it a default on Linux but also possible to disable it, should qt5-wayland fail to build for some.

NancyLi1013 · 2021-04-14T02:46:05Z

LGTM, thanks for your updates @wrobelda.

wrobelda · 2021-04-27T17:29:38Z

@NancyLi1013 any reason why this is still pending merging to master?

NancyLi1013 · 2021-04-28T02:10:36Z

@NancyLi1013 any reason why this is still pending merging to master?

No, there is nothing blocking. We're doing a big clean up PRs in these days. So this PR will be merged soon. Since there are many PRs that need to be merged. Maybe we need to wait for a moment.

BillyONeal · 2021-04-29T20:12:08Z

Sorry for the delay, we had a bunch of infrastructure related things on the floor (e.g. our MacOS build fleet dying because of changes to MacOS and brew) we've been working through. Merged with master to make sure this still works on the current VMs.

strega-nil-ms · 2021-04-29T23:24:12Z

/azp run

azure-pipelines · 2021-04-29T23:24:30Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil-ms · 2021-05-01T16:56:04Z

/azp run

azure-pipelines · 2021-05-01T16:56:13Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil-ms · 2021-05-05T20:27:04Z

/azp run

azure-pipelines · 2021-05-05T20:27:13Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-05-10T10:30:40Z

kf5windowssystem failed on x64-windows:

CMake Error: Could not open file for write in copy operation D:/buildtrees/kf5windowsystem/src/v5.81.0-e5ada730c9.clean/.clang-format.tmp
CMake Error: : System Error: Permission denied
CMake Error at D:/installed/x64-windows/share/ECM/kde-modules/KDEClangFormat.cmake:67 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  D:/installed/x64-windows/share/ECM/kde-modules/KDEFrameworkCompilerSettings.cmake:79 (include)
  CMakeLists.txt:16 (include)

kf5guiaddons failed on x64-windows:

CMake Error: Could not open file for write in copy operation D:/buildtrees/kf5guiaddons/src/v5.81.0-d7ffef2860.clean/.clang-format.tmp
CMake Error: : System Error: Permission denied
CMake Error at D:/installed/x64-windows/share/ECM/kde-modules/KDEClangFormat.cmake:67 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  D:/installed/x64-windows/share/ECM/kde-modules/KDEFrameworkCompilerSettings.cmake:79 (include)
  CMakeLists.txt:26 (include)

Seems like parallel problem. Could you please add DISABLE_PARALLEL_CONFIGURE in vcpkg_configure_cmake for these two ports?

wrobelda · 2021-05-18T22:45:57Z

@NancyLi1013 fixed. The zxing-cpp and dbow2 failures are unrelated.

NancyLi1013 · 2021-05-19T07:09:28Z

/azp run

azure-pipelines · 2021-05-19T07:09:37Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-05-19T08:10:11Z

As commented here #17983 (comment), zxing-cpp and dbow2 are related with opencv4. We have fixed the problems on opencv4, so zxing-cpp and dbow2 can work normally now.

wrobelda · 2021-05-19T19:13:23Z

As commented here #17983 (comment), zxing-cpp and dbow2 are related with opencv4. We have fixed the problems on opencv4, so zxing-cpp and dbow2 can work normally now.

~~Looks like clamav is failing now.~~ All fixed.

NancyLi1013 · 2021-05-20T01:44:36Z

LGTM now, thanks for your hard work. @wrobelda

wrobelda force-pushed the kf5_update_to_581 branch 9 times, most recently from d67a5c7 to d00bff5 Compare April 13, 2021 18:44

wrobelda commented Apr 13, 2021

View reviewed changes

wrobelda marked this pull request as ready for review April 13, 2021 19:09

NancyLi1013 self-assigned this Apr 14, 2021

NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 14, 2021

NancyLi1013 approved these changes Apr 14, 2021

View reviewed changes

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 14, 2021

wrobelda mentioned this pull request Apr 21, 2021

[kf5auth] new port #16559

Merged

NancyLi1013 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 10, 2021

NancyLi1013 added the requires:author-response label May 10, 2021

wrobelda force-pushed the kf5_update_to_581 branch from 64547a9 to dec0952 Compare May 18, 2021 22:06

NancyLi1013 approved these changes May 19, 2021

View reviewed changes

NancyLi1013 removed the requires:author-response label May 19, 2021

wrobelda force-pushed the kf5_update_to_581 branch from dec0952 to 2ca73e3 Compare May 19, 2021 19:38

wrobelda added 7 commits May 19, 2021 20:26

[many ports] Update KF5 frameworks to 5.81

aaef9af

[many ports] Update KF5 versions

a3bfd8d

[kf5guiaddons] disable parallel configure

2ccd880

[kf5windowsystem] disable parallel configure

c1e9db4

[many ports] Update KF5 versions

11a5c71

[kf5archive] disable parallel configure

aa16b4a

[many ports] Update KF5 versions

a4af157

wrobelda force-pushed the kf5_update_to_581 branch from 2ca73e3 to a4af157 Compare May 20, 2021 00:26

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 20, 2021

dan-shaw merged commit b34b7ff into microsoft:master May 21, 2021

wrobelda mentioned this pull request May 31, 2021

[kf5iconthemes] new port #16567

Merged

5 tasks

Conversation

wrobelda commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wrobelda Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hoikas Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

wrobelda Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hoikas Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

wrobelda Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Apr 14, 2021

Uh oh!

wrobelda commented Apr 27, 2021

Uh oh!

NancyLi1013 commented Apr 28, 2021

Uh oh!

BillyONeal commented Apr 29, 2021

Uh oh!

strega-nil-ms commented Apr 29, 2021

Uh oh!

azure-pipelines bot commented Apr 29, 2021

Uh oh!

strega-nil-ms commented May 1, 2021

Uh oh!

azure-pipelines bot commented May 1, 2021

Uh oh!

strega-nil-ms commented May 5, 2021

Uh oh!

azure-pipelines bot commented May 5, 2021

Uh oh!

NancyLi1013 commented May 10, 2021

Uh oh!

wrobelda commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented May 19, 2021

Uh oh!

azure-pipelines bot commented May 19, 2021

Uh oh!

NancyLi1013 commented May 19, 2021

Uh oh!

wrobelda commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented May 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wrobelda commented Apr 13, 2021 •

edited

Loading

wrobelda Apr 13, 2021 •

edited

Loading

wrobelda Apr 13, 2021 •

edited

Loading

Hoikas Apr 13, 2021 •

edited

Loading

wrobelda Apr 29, 2021 •

edited

Loading

wrobelda commented May 18, 2021 •

edited

Loading

wrobelda commented May 19, 2021 •

edited

Loading