[kf5iconthemes] new port

[wrobelda]

Describe the pull request

Adds kf5iconthemes. Depends on the following:

• [kf5configwidgets] new port #16562. I merged it into this PR, but please review separately.

• [kf5guiaddons] fix Wayland scanner not being found by transitive deps; fix static builds #19203. I merged it into this PR, but please review separately.

• [kf5archive] fix cmake.in to allow consumption by static builds #19194. I merged it into this PR, but please review separately.

• [gettext] msgfmt (and other gettext bin tools) missing on macOS & Windows #13518 [gettext] Add gettext cmake wrapper #18159

• [kf5i18n] static builds fixes #20016. I merged it into this PR, but please review separately.

• Which triplets are supported/not supported? Have you updated the CI baseline?
  All official should be supported.

• Does your PR follow the maintainer guide?
  Yes

[NancyLi1013]

Hi @wrobelda

Thanks for adding this new port.

I think it's unnecessary to add too many changes in this PR. You can only do something related to kf5iconthemes. After the dependent PR #14367 merged, you can update tiny changes.

[wrobelda]

Hi @wrobelda

Thanks for adding this new port.

I think it's unnecessary to add too many changes in this PR. You can only do something related to kf5iconthemes. After the dependent PR #14367 merged, you can update tiny changes.

Yeah, that's the plan. Once #13467 gets merged (which I understand is the one you refer to), I'll rebase this branch against master and it will only have changes related to kf5iconthemes. I opened this up early to see if everything builds fine.

[NancyLi1013]

@wrobelda
Thanks for your instant response. I posted some suggestions here, mainly including version updates in json files. Since this is a new policy, it might be not easy to notice this point.

Another question is about the port version. I noticed that there was another new release for these ports. Is it because all ports used version 5.75.0? So you update all ports to the same version?

[NancyLi1013]

Wow, Seems you need to rebase this PR now, many changes were brought in this PR. Or you can open a new pull request to adding this port.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout dd3d6df5001d49f954bc39b73a4c49ae3c9e8d15 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 0121857..477c311 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2932,6 +2932,10 @@
       "baseline": "5.84.0",
       "port-version": 1
     },
+    "kf5iconthemes": {
+      "baseline": "5.84.0",
+      "port-version": 0
+    },
     "kf5itemmodels": {
       "baseline": "5.84.0",
       "port-version": 1

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5iconthemes but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 5fd63e3d0747a6c3ba2e2f277acbd2e4129b7762
-- New SHA: a34b5beea612f36368ba352aab740da326efb961
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

[wrobelda]

@NancyLi1013 Windows CI tests were re-enabled and I triggered a run by rebasing, so this is now all ready for a review.

[BillyONeal]

Thanks for the new port :)