[taglib] Upgrade from 1.12-beta-2 to 1.12#16649
Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom Mar 11, 2021
Merged
[taglib] Upgrade from 1.12-beta-2 to 1.12#16649ras0219-msft merged 4 commits intomicrosoft:masterfrom
ras0219-msft merged 4 commits intomicrosoft:masterfrom
Conversation
- Replace CONTROL with vcpkg.json - Use Git tag as REF - Use official version number (without the date suffix) - Switch to semantic versioning - Link official homepage instead of GitHub project page - Add license string according to GitHub repo - Add missing vcpkg_fixup_pkgconfig() in portfile
JonLiu1993
added
the
category:port-update
JonLiu1993
approved these changes
Mar 11, 2021
JonLiu1993
added
the
info:needs-maintainer-attention
Contributor
Author
|
Please confirm that the versioning is correct after switching to semver. I don't want to mess up any existing dependencies. |
Be-ing
reviewed
Mar 11, 2021
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "name": "taglib", | |||
| "version-semver": "1.12.0", | |||
Contributor
Author
There was a problem hiding this comment.
According to the docs 1.12.0-yyyymmdd precedes 1.12.0. But someone else should confirm this.
https://vcpkg.readthedocs.io/en/latest/specifications/versioning/#2-specifying-package-versions
Contributor
There was a problem hiding this comment.
@Be-ing ,If we update the version, we will delete the port-version. If we modify the BUG or other changes, we will add the port-version: 1. If the port-version already exists, we will increment it by 1 each time we modify it.
Contributor
|
👍 Looks great to me, thanks for the update PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of:
Original changes:
Additional changes: