Update taglib to 1.12.0#16390
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom Feb 24, 2021
pdehne:master
Merged
Conversation
Contributor
|
Thanks for the update! |
Contributor
|
@ras0219-msft this was a duplicate of #16266... |
JackBoosY
reviewed
Mar 10, 2021
Comment on lines
+17
to
+18
| set(VCPKG_C_FLAGS "${VCPKG_C_FLAGS} /wd4996") | ||
| set(VCPKG_CXX_FLAGS "${VCPKG_CXX_FLAGS} /wd4996") |
Contributor
There was a problem hiding this comment.
That was reported to the upstream taglib/taglib#1000.
And I think we should wait for upstream confirm.
Contributor
There was a problem hiding this comment.
Replaced by a patch in #16649 to avoid keeping these warnings disabled for subsequent versions without noticing.
Contributor
There was a problem hiding this comment.
Upstream didn't respond. Edit: They did and acknowledged the issue.
JackBoosY
reviewed
Mar 10, 2021
Comment on lines
+9
to
+13
| if(VCPKG_CRT_LINKAGE STREQUAL static) | ||
| set(BUILD_SHARED_LIBS OFF) | ||
| else() | ||
| set(BUILD_SHARED_LIBS ON) | ||
| endif() |
Contributor
There was a problem hiding this comment.
We shouldn't judge the build of static libraries or dynamic libraries based on VCPKG_CRT_LINKAGE, because this will destroy other community triplets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Updates the port to 1.12.0
No changes related to triplets or CI.
Yes.