[many ports] Update existing KF5 frameworks to 5.75 by wrobelda · Pull Request #13467 · microsoft/vcpkg

wrobelda · 2020-09-11T01:14:23Z

kf5crash
- make x11 patch exclusive to linux
- enable win/macOS builds
kf5syntaxhighlighting
- fix building on non-Win by removing the cli tool from all platforms

Describe the pull request

Which triplets are supported/not supported? Have you updated the CI baseline?
No change in triplets supported.
Does your PR follow the maintainer guide?
Yes

kf5crash - make x11 patch exclusive to linux - enable win/macOS builds kf5syntaxhighlighting - fix building on non-Win by removing the cli tool from all platforms

ghost · 2020-09-11T01:14:37Z

All CLA requirements met.

wrobelda · 2020-09-11T01:33:13Z

My apologies, I pushed a new kf5auth port by mistake.

This reverts commit 8703c24.

wrobelda · 2020-09-11T02:25:35Z

@NancyLi1013 FYI, I reverted the new kf5auth I accidentally added

ports/ecm/portfile.cmake

ports/kf5holidays/portfile.cmake

ports/kf5syntaxhighlighting/portfile.cmake

ports/kf5plotting/portfile.cmake

This reverts commit f1ac3db.

NancyLi1013 · 2020-09-11T02:51:53Z

There is also another new port kf5globalaccel in this PR. Is this intended or by mistake?

Edit: I noticed that you have removed just now. Please ignore this comment.

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

NancyLi1013 · 2020-09-11T03:10:20Z

LGTM now. Thanks for your PR.

ras0219-msft

LGTM other than one question

ports/kf5crash/CONTROL

wrobelda · 2020-09-14T05:11:09Z

@ras0219 @NancyLi1013 similarly to what I reported under PR #13469, I see that all the modified ports in this PR were also labeled as CASCADE by the CI run, which to my understanding implies they were skipped due to a missing/failing dependency. In this case it looks that for some reason kf5crash is not being built with a n\a status – despite that works fine for me locally. Are the CI test results therefore a false positive, or am I missing something here?

NancyLi1013 · 2020-09-14T08:25:58Z

Your understanding is right. The build results are related with those dependencies.

wrobelda · 2020-09-14T15:06:42Z

@NancyLi1013 so I just run those builds locally on my Windows VM after learning they aren't actually being tested by the CI and I already had some failures. I don't believe I can consciously push this PR into the master unless we can actually have your CI to properly test all the supported triplets – I don't have the means to do so locally.

@ras0219-msft I see that the ecm was excluded as part of this change of yours. May we know wat was wrong with ecm? The pull request doesn't mention anything specific about it.

ports/ecm/portfile.cmake

ports/kf5archive/portfile.cmake

ports/kf5holidays/portfile.cmake

ports/kf5syntaxhighlighting/portfile.cmake

ports/kf5holidays/portfile.cmake

NancyLi1013 · 2021-03-09T02:39:14Z

Hi @wrobelda

I'm so sorry for updates many times, I reviewed this PR again and gave some extra suggestions. Please address them if you're free.

LGTM now except for these review suggestions. The only problem is the failure on Linux, which is not related with the changes in this PR, but we still recommend to merge this PR after all CI checks passed.

So we need to wait for the PR #15808 merged.

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

wrobelda · 2021-03-09T05:04:07Z

I'm so sorry for updates many times, I reviewed this PR again and gave some extra suggestions. Please address them if you're free.

Absolutely, nothing to apologize for! I totally understand we're held to high standards here and I appreciate your continuous feedback. All suggestions were addressed.

NancyLi1013 · 2021-03-09T07:42:19Z

There is nothing need to be done on your sides now, Let's wait for the PR #15808 merged.

wrobelda · 2021-03-18T07:15:06Z

@NancyLi1013 it looks like #15808 has stalled. Is there anything else that can be done to obtain an unobstructed Linux CI/CD run and have this merged?

NancyLi1013 · 2021-03-18T07:29:42Z

@wrobelda

Sorry, there is nothing to do except for waiting it merged. Unless the errors on Linux will disappear.

NancyLi1013 · 2021-03-18T07:29:51Z

/azp run

azure-pipelines · 2021-03-18T07:30:03Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-04-02T06:41:46Z

c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory

Will be fixed by another PR #16954

NancyLi1013 · 2021-04-07T09:57:28Z

/azp run

azure-pipelines · 2021-04-07T09:57:47Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-04-08T02:07:43Z

LGTM now, thanks for your hard work and patience @wrobelda.

Update KF5 framework to 5.73

e10a483

kf5crash - make x11 patch exclusive to linux - enable win/macOS builds kf5syntaxhighlighting - fix building on non-Win by removing the cli tool from all platforms

wrobelda marked this pull request as ready for review September 11, 2020 01:23

Add kf5auth port

8703c24

NancyLi1013 self-assigned this Sep 11, 2020

NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 11, 2020

Revert "Add kf5auth port"

760bd50

This reverts commit 8703c24.

wrobelda changed the title ~~Update KF5 framework to 5.73~~ [kf5-*] Update KF5 frameworks to 5.73 Sep 11, 2020

wrobelda changed the title ~~[kf5-*] Update KF5 frameworks to 5.73~~ [kf5*] Update KF5 frameworks to 5.73 Sep 11, 2020

Add kf5globalaccel port

f1ac3db

NancyLi1013 suggested changes Sep 11, 2020

View reviewed changes

ports/ecm/portfile.cmake Show resolved Hide resolved

ports/kf5holidays/portfile.cmake Show resolved Hide resolved

ports/kf5syntaxhighlighting/portfile.cmake Outdated Show resolved Hide resolved

ports/kf5plotting/portfile.cmake Show resolved Hide resolved

Revert "Add kf5globalaccel port"

0d9ca95

This reverts commit f1ac3db.

wrobelda and others added 4 commits September 10, 2020 22:53

[ecm] use where possible

26d8897

[kf5holidays] use PORT placeholder where possible

508b8c5

[kf5syntaxhighlighting] use PORT placeholder where possible

836bf71

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

[kf5plotting] use PORT placeholder where possible

f2a9740

NancyLi1013 approved these changes Sep 11, 2020

View reviewed changes

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 11, 2020

NancyLi1013 mentioned this pull request Sep 11, 2020

[many ports] Add more KF5 frameworks #13469

Closed

ras0219-msft reviewed Sep 11, 2020

View reviewed changes

ports/kf5crash/CONTROL Outdated Show resolved Hide resolved

wrobelda added 2 commits September 13, 2020 01:21

[kf5crash] fix logical condition in the patch

6ad1abd

[kf5crash] logical condition again, include other BSDs

c3f6c72

[kf5i18n] acquire python3

92adab8

NancyLi1013 suggested changes Mar 9, 2021

View reviewed changes

ports/kf5holidays/portfile.cmake Outdated Show resolved Hide resolved

wrobelda and others added 9 commits March 8, 2021 23:12

[ecm] syntax formatting

5e3c5aa

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

[kf5syntaxhighlighting] syntax formatting

f4a19f2

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

[kf5holidays] syntax formatting

a0e0a4c

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

[kf5archive] restore original line order

3bac05c

[kf5holidays] restore CRLF

cf054e0

[kf5archive] restore CRLF

d10df4e

[kf5syntaxhighlighting] syntax formatting

b144c5d

[kf5syntaxhighlighting] quotations

5b7e011

[kf5syntaxhighlighting] fix \bin removal redundancy

514fe86

[kf5*] update versions

bd31fe6

NancyLi1013 removed the requires:author-response label Mar 9, 2021

NancyLi1013 approved these changes Mar 9, 2021

View reviewed changes

NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 7, 2021

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 8, 2021

autoantwort mentioned this pull request Apr 9, 2021

kf5completion build failure #17185

Closed

vicroms merged commit bc96cd5 into microsoft:master Apr 12, 2021

JackBoosY mentioned this pull request Jul 30, 2021

[vcpkg-cmake] Fix docs and usage of option MAYBE_UNUSED_VARIABLES #19245

Merged

Conversation

wrobelda commented Sep 11, 2020

Uh oh!

ghost commented Sep 11, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wrobelda commented Sep 11, 2020

Uh oh!

wrobelda commented Sep 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Sep 11, 2020

Uh oh!

ras0219-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wrobelda commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Sep 14, 2020

Uh oh!

wrobelda commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Mar 9, 2021

Uh oh!

wrobelda commented Mar 9, 2021

Uh oh!

NancyLi1013 commented Mar 9, 2021

Uh oh!

wrobelda commented Mar 18, 2021

Uh oh!

NancyLi1013 commented Mar 18, 2021

Uh oh!

NancyLi1013 commented Mar 18, 2021

Uh oh!

azure-pipelines bot commented Mar 18, 2021

Uh oh!

NancyLi1013 commented Apr 2, 2021

Uh oh!

NancyLi1013 commented Apr 7, 2021

Uh oh!

azure-pipelines bot commented Apr 7, 2021

Uh oh!

NancyLi1013 commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ghost commented Sep 11, 2020 •

edited by ghost

Loading

NancyLi1013 commented Sep 11, 2020 •

edited

Loading

wrobelda commented Sep 14, 2020 •

edited

Loading

wrobelda commented Sep 14, 2020 •

edited

Loading