Skip to content

[wxwidgets] Fix cmake wrapper#16546

Merged
strega-nil merged 6 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16543
Apr 20, 2021
Merged

[wxwidgets] Fix cmake wrapper#16546
strega-nil merged 6 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16543

Conversation

@JackBoosY
Copy link
Contributor

Since the target of libpng in static is libpng_static, fix the usage issue.

Fixes #16543.
suspend #16544.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Mar 5, 2021
@JackBoosY JackBoosY marked this pull request as draft March 5, 2021 02:58
@JackBoosY
Copy link
Contributor Author

Will also fix #16545 in this PR.

@Hoikas
Copy link
Contributor

Hoikas commented Mar 5, 2021

I think it would be better to patch the png target to erase the difference between png and png_static.

@JackBoosY
Copy link
Contributor Author

@Hoikas I think we'd better don't do that because it's official.

@JackBoosY JackBoosY marked this pull request as ready for review April 13, 2021 08:40
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

Depends on #17277.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 14, 2021
@JackBoosY JackBoosY requested a review from PhoebeHui April 15, 2021 02:34
@PhoebeHui
Copy link
Contributor

@Hoikas, Similar discussion in #14930.

Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 16, 2021
@strega-nil strega-nil merged commit 3e9fce2 into microsoft:master Apr 20, 2021
@JackBoosY JackBoosY deleted the dev/jack/16543 branch April 20, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wxWidgets] static triplet only debug/release library mixup [wxWidgets] Using static triplet fails because of missing png.lib

4 participants