[wxWidgets] Use libpng CMake target#16544
Closed
brad-anderson wants to merge 1 commit intomicrosoft:masterfrom
Closed
[wxWidgets] Use libpng CMake target#16544brad-anderson wants to merge 1 commit intomicrosoft:masterfrom
brad-anderson wants to merge 1 commit intomicrosoft:masterfrom
Conversation
libpng uses png_static library name on static triplets. Using the CMake target fixes wxWidget's cmake wrapper so it works on static triplets.
JackBoosY
added
category:port-bug
Contributor
|
We should modify the cmake wrapper instead of this. |
Contributor
Author
Perhaps I'm missing something but is that not what this PR does? |
Contributor
|
vcpkg's libpng port exports a config named |
Contributor
|
Since my PR #16546 was merged. can I close this PR now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpng uses png_static library name on static triplets. Using the CMake target fixes wxWidget's cmake wrapper so it works on static triplets.
Describe the pull request
Updates wxWidget's cmake wrapper to use the libpng CMake target instead of referring to the libpng library by name.
What does your PR fix?
Fixes [wxWidgets] Using static triplet fails because of missing png.lib #16543
Which triplets are supported/not supported? Have you updated the CI baseline?
Adds partial support for static triplets (unrelated issues remain related to release/debug library mixup [wxWidgets] static triplet only debug/release library mixup #16545)
Does your PR follow the maintainer guide?
Yes, I hope.