Skip to content

[vcpkg baseline][armadillo] Update to 10.2.0 and also update the repository#15973

Merged
ras0219-msft merged 5 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-armadillo
Feb 3, 2021
Merged

[vcpkg baseline][armadillo] Update to 10.2.0 and also update the repository#15973
ras0219-msft merged 5 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-armadillo

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix? Fixes #

-- Downloading https://gitlab.com/conradsnicta/armadillo-code/-/archive/24b4762cbfbd3ad14c99a4854acd3560559a3195/armadillo-code-24b4762cbfbd3ad14c99a4854acd3560559a3195.tar.gz... Failed. Status: 22;"HTTP response code said error"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):

      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".

      If error with status 4 (Issue #15434),
      try setting "http://user:password@your-proxy-ip-address:port/".

      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Update the repository from sourceforge since there is something wrong with the server on GitLab.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal category:port-update The issue is with a library, which is requesting update new revision labels Feb 1, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

Hi @NancyLi1013, I checked in a workaround for v10.1.0 as part of #15677 -- could you simply update this PR to be based off master? I'd like to move to using vcpkg_from_sourceforge() over vcpkg_from_git() (as you have it here).

@NancyLi1013
Copy link
Copy Markdown
Contributor Author

Thanks for your information @ras0219-msft. I will update it later.

…NancyLi/fix-armadillo

# Conflicts:
#	ports/armadillo/CONTROL
#	ports/armadillo/portfile.cmake
#	versions/a-/armadillo.json
#	versions/baseline.json
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 3, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

Ping @ras0219 @ras0219-msft for review and merge this PR quickly.

@ras0219-msft ras0219-msft merged commit e76c524 into microsoft:master Feb 3, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants