[vcpkg_find_acquire_program] Add tool powershell#15728
Closed
JackBoosY wants to merge 13 commits intomicrosoft:masterfrom
Closed
[vcpkg_find_acquire_program] Add tool powershell#15728JackBoosY wants to merge 13 commits intomicrosoft:masterfrom
JackBoosY wants to merge 13 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
info:internal
category:tool-update
JackBoosY
added
the
depends:different-pr
Contributor
Author
|
Waiting for #15740. |
JackBoosY
removed
the
depends:different-pr
Contributor
Author
|
@skywalkerisnull Can you please test this PR? Thanks. |
strega-nil
force-pushed
the
dev/jack/15681
branch
from
04115ee to
6a0d451
Compare
added 2 commits
January 21, 2021 18:25
wangzishi
reviewed
Jan 29, 2021
JackBoosY
commented
Jan 29, 2021
Contributor
Author
|
Regressions will be fixed in #15973. |
JackBoosY
added
the
depends:different-pr
JackBoosY
removed
the
depends:different-pr
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
added
the
info:needs-maintainer-attention
PhoebeHui
approved these changes
Feb 7, 2021
Contributor
|
Blocked on getting a response for #15681 (comment). Vcpkg should already be adding pwsh.exe to the path as part of the main invocation and it should not be needed to |
JackBoosY
removed
the
info:needs-maintainer-attention
Contributor
|
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
powershelltovcpkg_find_acquire_programto fix the issue that couldn't find powershell correctly.Fixes #15681.