[pcl] Fix build when librealsense2 is present#14960
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Dec 9, 2020
Merged
[pcl] Fix build when librealsense2 is present#14960BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
|
|
NancyLi1013
reviewed
Dec 7, 2020
Contributor
NancyLi1013
left a comment
NancyLi1013
left a comment
There was a problem hiding this comment.
Could you please update version in CONTROL file?
NancyLi1013
added
category:port-bug
dweckmann
force-pushed
the
pcl-fix-realsense2-grabber
branch
2 times, most recently
from
131fe9c to
b7129f1
Compare
Contributor
Author
|
@NancyLi1013 : You mean setting |
dweckmann
force-pushed
the
pcl-fix-realsense2-grabber
branch
from
b7129f1 to
1d11038
Compare
NancyLi1013
suggested changes
Dec 9, 2020
dweckmann
force-pushed
the
pcl-fix-realsense2-grabber
branch
from
1d11038 to
f315f8e
Compare
NancyLi1013
approved these changes
Dec 9, 2020
Contributor
|
Have you tested these features included in this PR? |
Contributor
Author
Well, I've tested that it builds and that I can integrate it into our project. We do not rely directly on librealsense2 inside PCL, but use both of them separately. |
Contributor
|
Thanks for your feedback. LGTM now. |
NancyLi1013
added
the
info:needs-maintainer-attention
Member
|
Thanks for submitting upstream and your contribution here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
When librealsens2 is installed, PCL want to build realsense2 grabber. The file
io/src/real_sense_2_grabber.cppmiscompile and this patch fix it. (Upstream's master have the same modification)Should support everything, since the problem is present in
real_sense_2_grabber.cppand it is used in all triplets. However, the autodetection of librealsense is curious and this should be a feature that set a dependency to the librealsense2 package. Anyway, this patch will be still required, so it can be already applied.Not sure, but it should.