Skip to content

[harfbuzz] fix icu linkage#14530

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
Neumann-A:harfbuzz_fix_icu_linkage
Nov 12, 2020
Merged

[harfbuzz] fix icu linkage#14530
strega-nil merged 1 commit intomicrosoft:masterfrom
Neumann-A:harfbuzz_fix_icu_linkage

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Nov 11, 2020

just fixing the icu linkage in harfbuzz
discovered in #14333 due to CI failing (qt6-)qtbase builds.

This was referenced Nov 11, 2020
Merged
Merged
@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 12, 2020
PhoebeHui
PhoebeHui approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

All features test passed with x64-windows.

@PhoebeHui PhoebeHui added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Nov 12, 2020
@strega-nil strega-nil merged commit a07107b into microsoft:master Nov 12, 2020
@Neumann-A Neumann-A deleted the harfbuzz_fix_icu_linkage branch November 12, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neumann-A @PhoebeHui @strega-nil @NancyLi1013