[ZSTD] Update to 1.4.5

[Neumann-A]

simple port update.

[Neumann-A]

Hmm I cannot reproduce the qt5-base error locally.

[BillyONeal]

@Neumann-A We've been experiencing intermittent qt related failures like that for months now :(

[Neumann-A]

@BillyONeal: Is this jom failing? From the logs I cannot deduce what happened.

[BillyONeal]

jom 1.1.3 - empower your cores

cl : Command line warning D9025 : overriding '/Fo./' with '/Foqlibraryinfo_final.obj'
WARNING: Failure to find: D:/buildtrees/qt5-base/x64-windows-dbg/src/corelib/qt5cored_metatypes.json
WARNING: Failure to find: D:/buildtrees/qt5-base/x64-windows-dbg/src/corelib/qt5core_metatypes.json
D:\buildtrees\qt5-base\src\5.15.1-63a9328040.clean\src\corelib\kernel\qobjectdefs.h(0): Note: No relevant classes found. No output generated.
WARNING: Failure to find: D:/buildtrees/qt5-base/x64-windows-dbg/src/gui/qt5guid_metatypes.json
WARNING: Failure to find: D:/buildtrees/qt5-base/x64-windows-dbg/src/gui/qt5gui_metatypes.json
jom: D:\buildtrees\qt5-base\x64-windows-dbg\src\gui\Makefile.Debug [vulkan\qvulkanfunctions.h] Error 2
jom: D:\buildtrees\qt5-base\x64-windows-dbg\src\gui\Makefile [debug] Error 2
jom: D:\buildtrees\qt5-base\x64-windows-dbg\src\Makefile [sub-gui-make_first] Error 2
D:\buildtrees\qt5-base\src\5.15.1-63a9328040.clean\src\network\access\qnetworkaccessdebugpipebackend_p.h(0): Note: No relevant classes found. No output generated.
jom: D:\buildtrees\qt5-base\x64-windows-dbg\Makefile [sub-src-make_first] Error 2

I'm not sure what this means either.
build-x64-windows-dbg-out.log

[Neumann-A]

The relevant first error is :
jom: D:\buildtrees\qt5-base\x64-windows-dbg\src\gui\Makefile.Debug [vulkan\qvulkanfunctions.h] Error 2

which probably tries to run

vulkan\qvulkanfunctions.h: E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\src\5.15.1-63a9328040.clean\src\gui\vulkan\vk.xml
	call E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\x64-windows-static-dbg\src\gui\qvkgen_wrapper.bat E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\src\5.15.1-63a9328040.clean\src\gui\vulkan\vk.xml E:/vcpkg_folders/qt6_2/buildtrees/qt5-base/src/5.15.1-63a9328040.clean/header.LGPL vulkan/qvulkanfunctions

with the bat file (of course paths are wrong.):

@echo off
SetLocal EnableDelayedExpansion
(set PATH=E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\x64-windows-static-dbg\bin;!PATH!)
if defined QT_PLUGIN_PATH (
    set QT_PLUGIN_PATH=E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\x64-windows-static-dbg\plugins;!QT_PLUGIN_PATH!
) else (
    set QT_PLUGIN_PATH=E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\x64-windows-static-dbg\plugins
)
E:\vcpkg_folders\qt6_2\buildtrees\qt5-base\x64-windows-static-dbg\bin\qvkgen.exe %*
EndLocal

Since the static build is succeeding I assume it is a DLL issue and something is loading the wrong DLL?

[Neumann-A]

@BillyONeal Highly likely that #14530 will fix the qt5-base build issues. harfbuzz was linking against release icuuc in debug builds and thus the required dll was not on path for a the qt5-base debug build. The problem here is that the feature harfbuzz[icu] is not required by qt5-base and also not a default feature which made discovering it in local builds impossible.

[BillyONeal]

Ooooooh thanks! :D

/cc @ras0219 @ras0219-msft since he was looking into that stuff

[strega-nil]

Thanks @Neumann-A :)