[libjuice] Add new port by Nemirtingas · Pull Request #13703 · microsoft/vcpkg

Nemirtingas · 2020-09-24T07:58:29Z

Describe the pull request

What does your PR fix? Fixes issue [New Port Request] libdatachannel #13487, I'm also creating a port for libdatachannel.
Which triplets are supported/not supported?
I tested on lwindows x86, x64 static library, static CRT, it works.
I tested on linux, windows x86, x64 static library, it works.
I tested on linux, windows x86, x64 dynamic library, it works.
Have you updated the CI baseline? Hum, no ?
Does your PR follow the maintainer guide?
The base CMake file builds 2 distinct libraries for static (which is not exported) and dynamic library. I've patched the CMakeLists.txt to build only the shared library and set it static if static library is picked in vcpkg.

This is my first port, please review carefully,

ports/libjuice/CONTROL

ports/libjuice/portfile.cmake

ports/libjuice/fix-for-vcpkg.patch

ras0219-msft · 2020-09-28T00:29:54Z

/azp run

azure-pipelines · 2020-09-28T00:30:06Z

Azure Pipelines successfully started running 1 pipeline(s).

Nemirtingas

Changed in last version

ras0219-msft

Thanks for the PR!

This overall looks like a really great PR; I just have a few more suggestions on how to reduce the size of the patch file. Minimizing the number of lines changed is really important to make upgrading in the future seamless :)

ports/libjuice/fix-for-vcpkg.patch

ports/libjuice/CONTROL

scripts/ci.baseline.txt

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

NancyLi1013 · 2020-10-13T06:16:16Z

The failures on x64-uwp and arm-uwp:

4>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' specification [D:\buildtrees\libjuice\x64-uwp-dbg\juice.vcxproj]
            Creating library D:/buildtrees/libjuice/x64-uwp-dbg/Debug/juice.lib and object D:/buildtrees/libjuice/x64-uwp-dbg/Debug/juice.exp
     4>random.obj : error LNK2019: unresolved external symbol CryptAcquireContext referenced in function random_bytes [D:\buildtrees\libjuice\x64-uwp-dbg\juice.vcxproj]
     4>D:\buildtrees\libjuice\x64-uwp-dbg\Debug\juice.dll : fatal error LNK1120: 1 unresolved externals [D:\buildtrees\libjuice\x64-uwp-dbg\juice.vcxproj]
     4>Done Building Project "D:\buildtrees\libjuice\x64-uwp-dbg\juice.vcxproj" (default targets) -- FAILED.
     3>Done Building Project "D:\buildtrees\libjuice\x64-uwp-dbg\ALL_BUILD.vcxproj" (default targets) -- FAILED.
     1>Done Building Project "D:\buildtrees\libjuice\x64-uwp-dbg\install.vcxproj" (default targets) -- FAILED.

Could you please look into this and try to fix it?

Nemirtingas · 2020-10-13T06:25:30Z

random_bytes

Hi,
I'm asking the library owner if he wants to switch to the new crypto API.

Nemirtingas · 2020-10-13T10:51:14Z

Looks to build now.

Nemirtingas

Fixed

NancyLi1013 · 2020-10-14T02:02:43Z

Thanks for your quick fix.
LGTM now.

Could you please help confirm if you have tested the feature nettle? Does it work fine? If you didn't test it, I will do this later.

Nemirtingas · 2020-10-14T02:53:53Z

Thanks for your quick fix.
LGTM now.

Could you please help confirm if you have tested the feature nettle? Does it work fine? If you didn't test it, I will do this later.

Nettle has issue when building on Linux.

cat /vcpkg_libjuice/buildtrees/gmp/autoconf-x64-linux-err.log
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force 
configure.ac:3782: warning: AC_LIBTOOL_PROG_COMPILER_PIC is m4_require'd but not m4_defun'd
acinclude.m4:2363: GMP_ASM_X86_GOT_UNDERSCORE is expanded from...
configure.ac:3782: the top level
configure.ac:3785: warning: AC_ENABLE_SHARED is m4_require'd but not m4_defun'd
acinclude.m4:2717: GMP_ASM_X86_MCOUNT is expanded from...
configure.ac:3785: the top level
configure.ac:3785: warning: AC_PROG_LIBTOOL is m4_require'd but not m4_defun'd
acinclude.m4:2717: GMP_ASM_X86_MCOUNT is expanded from...
configure.ac:3785: the top level
autoreconf: configure.ac: tracing
configure.ac:3782: warning: AC_LIBTOOL_PROG_COMPILER_PIC is m4_require'd but not m4_defun'd
acinclude.m4:2363: GMP_ASM_X86_GOT_UNDERSCORE is expanded from...
configure.ac:3782: the top level
configure.ac:3785: warning: AC_ENABLE_SHARED is m4_require'd but not m4_defun'd
acinclude.m4:2717: GMP_ASM_X86_MCOUNT is expanded from...
configure.ac:3785: the top level
configure.ac:3785: warning: AC_PROG_LIBTOOL is m4_require'd but not m4_defun'd
acinclude.m4:2717: GMP_ASM_X86_MCOUNT is expanded from...
configure.ac:3785: the top level
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf --force
configure.ac:3782: warning: AC_LIBTOOL_PROG_COMPILER_PIC is m4_require'd but not m4_defun'd
acinclude.m4:2363: GMP_ASM_X86_GOT_UNDERSCORE is expanded from...
configure.ac:3782: the top level
configure.ac:3785: warning: AC_ENABLE_SHARED is m4_require'd but not m4_defun'd
acinclude.m4:2717: GMP_ASM_X86_MCOUNT is expanded from...
configure.ac:3785: the top level
configure.ac:3785: warning: AC_PROG_LIBTOOL is m4_require'd but not m4_defun'd
acinclude.m4:2717: GMP_ASM_X86_MCOUNT is expanded from...
configure.ac:3785: the top level
configure.ac:2663: error: possibly undefined macro: AC_LIBTOOL_WIN32_DLL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:2753: error: possibly undefined macro: AC_PROG_LIBTOOL
configure.ac:2876: error: possibly undefined macro: AC_CHECK_LIBM
configure:11252: error: possibly undefined macro: AC_PROG_NM
configure:15215: error: possibly undefined macro: AC_LIBTOOL_PROG_COMPILER_PIC
configure:15310: error: possibly undefined macro: AC_ENABLE_SHARED
autoreconf: /usr/bin/autoconf failed with exit status: 1

But looks fine on Windows, I forgot to add the include dir for nettle, which is solved now.
Didn't test MacOS.

Nemirtingas · 2020-10-14T09:21:31Z

Thanks for your quick fix.
LGTM now.
Could you please help confirm if you have tested the feature nettle? Does it work fine? If you didn't test it, I will do this later.

Nettle has issue when building on Linux.

Nettle works on Linux too, it appears that you need the native autoconf, libtool and gettext installed. (apt install autoconf libtool gettext).

Nemirtingas · 2020-10-14T09:31:11Z

One last little fix. The nettle target Nettle::Nettle didn't exist. Instead it is just called nettle.

Nemirtingas · 2020-10-15T10:53:47Z

Looks like the macos runner has crashed.

Nemirtingas · 2020-10-21T14:52:45Z

Hi,
Any news about this ?

…uice_port

NancyLi1013 · 2020-10-22T07:15:25Z

Hi @Nemirtingas

Thanks for your kindly reminder. Sorry for the delay.
I will merge master to this PR to retrigger CI.

NancyLi1013 · 2020-10-22T07:42:02Z

LGTM now. Thanks for this PR.

Nemirtingas · 2020-10-22T08:24:18Z

Thanks.

ras0219-msft · 2020-10-23T07:32:32Z

LGTM, thanks for the PR and fixing all the comments :)

libjuice port

f4ebf02

JackBoosY assigned NancyLi1013 Sep 24, 2020

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 24, 2020

NancyLi1013 suggested changes Sep 24, 2020

View reviewed changes

NancyLi1013 added the requires:author-response label Sep 24, 2020

NancyLi1013 changed the title ~~libjuice port~~ [libjuice] Add new port Sep 24, 2020

Nemirtingas mentioned this pull request Sep 24, 2020

[Discussion] vcpkg port paullouisageneau/libdatachannel#183

Closed

GameDumper added 2 commits September 25, 2020 11:35

Various fix from pr.

a3cd267

Remove unused code

5f7ba07

Update to v0.5.2

1aca81c

Nemirtingas requested a review from NancyLi1013 October 1, 2020 05:34

Add the private include file for datachannel

93465e6

Nemirtingas commented Oct 1, 2020

View reviewed changes

ras0219-msft requested changes Oct 6, 2020

View reviewed changes

Smaller patch for vcpkg

de48669

Nemirtingas requested a review from ras0219-msft October 7, 2020 12:15

NancyLi1013 suggested changes Oct 9, 2020

View reviewed changes

ports/libjuice/CONTROL Outdated Show resolved Hide resolved

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

Nemirtingas and others added 2 commits October 9, 2020 11:09

Update ports/libjuice/CONTROL

e4c9e86

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

Update scripts/ci.baseline.txt

85b7652

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

Nemirtingas requested a review from NancyLi1013 October 9, 2020 09:15

Nemirtingas mentioned this pull request Oct 12, 2020

[portaudio] Fix build on windows #13982

Merged

This was referenced Oct 13, 2020

[libdatachannel] Add new port #13704

Merged

[Windows] Secure random generator paullouisageneau/libjuice#44

Closed

Update libjuice to support uwp ?

b489167

Nemirtingas commented Oct 13, 2020

View reviewed changes

NancyLi1013 approved these changes Oct 14, 2020

View reviewed changes

Add nettle include path

0118824

Fix the nettle library name

c6aa880

Merge branch 'master' of https://github.com/Microsoft/vcpkg into libj…

3030dee

…uice_port

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Oct 22, 2020

ras0219-msft merged commit 5b93dab into microsoft:master Oct 23, 2020

Nemirtingas deleted the libjuice_port branch October 23, 2020 10:18

Conversation

Nemirtingas commented Sep 24, 2020 • edited by LilyWangL Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ras0219-msft commented Sep 28, 2020

Uh oh!

azure-pipelines bot commented Sep 28, 2020

Uh oh!

Nemirtingas left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Oct 13, 2020

Uh oh!

Nemirtingas commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nemirtingas commented Oct 13, 2020

Uh oh!

Nemirtingas left a comment

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Oct 14, 2020

Uh oh!

Nemirtingas commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nemirtingas commented Oct 14, 2020

Uh oh!

Nemirtingas commented Oct 14, 2020

Uh oh!

Nemirtingas commented Oct 15, 2020

Uh oh!

Nemirtingas commented Oct 21, 2020

Uh oh!

NancyLi1013 commented Oct 22, 2020

Uh oh!

NancyLi1013 commented Oct 22, 2020

Uh oh!

Nemirtingas commented Oct 22, 2020

Uh oh!

ras0219-msft commented Oct 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nemirtingas commented Sep 24, 2020 •

edited by LilyWangL

Loading

Nemirtingas commented Oct 13, 2020 •

edited

Loading

Nemirtingas commented Oct 14, 2020 •

edited

Loading