[portaudio] Fix build on windows

[Nemirtingas]

Describe the pull request

• What does your PR fix? I couldn't build portaudio on windows. This fixes this, and now we also only build static when static linking or shared when shared linking.

[Hoikas]

This doesn't look right. It would be better, I think, to forgo the patch and instead set -DPA_BUILD_SHARED correctly in the vcpkg_configure_cmake call in portfile.cmake. You could figure out the correct value by doing something like:

string(COMPARE EQUAL ${VCPKG_LIBRARY_LINKAGE} dynamic PA_BUILD_SHARED)

[Nemirtingas]

This doesn't look right. It would be better, I think, to forgo the patch and instead set -DPA_BUILD_SHARED correctly in the vcpkg_configure_cmake call in portfile.cmake. You could figure out the correct value by doing something like:

string(COMPARE EQUAL ${VCPKG_LIBRARY_LINKAGE} dynamic PA_BUILD_SHARED)

But the static build add a -static to the library name, when reading the vcpkg documentation its written that its better to have 1 name for both static and dynamic libs.

[Hoikas]

Ok. Looking at the upstream CMakeLists.txt, if PA_LIBNAME_ADD_SUFFIX is set to OFF, the static suffix is not added (source) on all non-MSVC compilers. There is code in the CMakeLists to force it on MSVC, but the fix-library-can-not-be-found.patch patch should fix that issue. So, I'm not really sure where the problem is.

It does look like we need to appropriately set PA_BUILD_STATIC in the portfile, though.

string(COMPARE EQUAL ${VCPKG_LIBRARY_LINKAGE} static PA_BUILD_STATIC)

[Nemirtingas]

When I built it on linux, I got 1 static and 1 dynamic libraries even if the LINKAGE was static. I triied to set PA_BUILD_STATIC and PA_BUILD_SHARED but it still exports the library as portaudio_static

The package portaudio:x64-linux provides CMake targets:

    find_package(portaudio CONFIG REQUIRED)
    target_link_libraries(main PRIVATE portaudio_static)

even if the output name is actually portaudio.a

ls -l installed/x64-linux/lib/libportaudio.a
-rw-r--r-- 1 root root 264474 oct.  12 07:33 installed/x64-linux/lib/libportaudio.a

[NancyLi1013]

Please also update version in CONTROL file.

Update
Version: 2020-02-02
as
Version: 2020-02-02
Port-Version: 1
.
Please see https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#update-the-port-version-field-in-the-manifest-file-of-any-modified-ports

[Nemirtingas]

Woops, yes sorry, I forgot to push it.