-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[folly/fizz/wangle/proxygen/fbthrift] Update to latest revision #13701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7f578b4
[folly] Update to latest revision
PhoebeHui d041383
Fix typo issue
PhoebeHui b1402bd
Remove Port-Version
PhoebeHui 0daad6b
[fizz] update to latest revision
PhoebeHui bdb021c
[wangle] update to latest revision
PhoebeHui 0bea132
[proxygen] Update to latest release
PhoebeHui fd194eb
Fix folly static link issue
PhoebeHui 1a60642
Merge branch 'master' into dev/Phoebe/folly
PhoebeHui 62b009a
Update ports/folly/portfile.cmake
JackBoosY 9fd9882
fix tools path for proxygen
PhoebeHui 97f2718
Merge branch 'master' into dev/Phoebe/folly
PhoebeHui d5ab1d1
Resolve conflicts
PhoebeHui 2f8fa05
Remove unused patch
PhoebeHui 953c532
Update to latest revision for fix folly build failure on osx
PhoebeHui 1962a9f
[fbthrift] Update to latest revision
PhoebeHui 6f5d24d
Install gperf on macos machine
PhoebeHui 8fc84be
Disable proxygen:x64-osx temporarily
PhoebeHui 9318048
Remove the unused patch for proxygen
PhoebeHui da579bc
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal 0cf8002
Fix proxygen supports:.
BillyONeal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Source: fizz | ||
| Version: 2020.02.03.00 | ||
| Port-Version: 1 | ||
| Version: 2020.10.19.00 | ||
| Homepage: https://github.com/facebookincubator/fizz | ||
| Build-Depends: folly, openssl, libsodium, zlib, fmt | ||
| Description: a TLS 1.3 implementation by Facebook |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| diff --git a/fizz/CMakeLists.txt b/fizz/CMakeLists.txt | ||
| index 0c95883..52585aa 100644 | ||
| index 7e3347b..76ee974 100644 | ||
| --- a/fizz/CMakeLists.txt | ||
| +++ b/fizz/CMakeLists.txt | ||
| @@ -86,6 +86,9 @@ else() | ||
| @@ -89,6 +89,9 @@ else() | ||
| list(APPEND FIZZ_INCLUDE_DIRECTORIES ${LIBEVENT_INCLUDE_DIR}) | ||
| endif() | ||
|
|
||
| +find_package(ZLIB REQUIRED) | ||
| +list(APPEND FIZZ_SHINY_DEPENDENCIES ZLIB::ZLIB) | ||
| + | ||
| set(FIZZ_HEADER_DIRS | ||
| base | ||
| client | ||
| crypto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,22 @@ | ||
| diff --git a/folly/portability/PThread.cpp b/folly/portability/PThread.cpp | ||
| index 5cc3731..86a4a0b 100644 | ||
| --- a/folly/portability/PThread.cpp | ||
| +++ b/folly/portability/PThread.cpp | ||
| @@ -18,6 +18,9 @@ | ||
|
|
||
| #if !FOLLY_HAVE_PTHREAD && defined(_WIN32) | ||
| #include <boost/thread/tss.hpp> // @manual | ||
| +#include <boost/thread/exceptions.hpp> | ||
| +#include <boost/shared_ptr.hpp> | ||
| +#include <boost/thread/thread_only.hpp> | ||
|
|
||
| #include <errno.h> | ||
|
|
||
| @@ -684,7 +687,7 @@ int pthread_setspecific(pthread_key_t key, const void* value) { | ||
| // function, which we don't want to do. | ||
| boost::detail::set_tss_data( | ||
| realKey, | ||
| - boost::shared_ptr<boost::detail::tss_cleanup_function>(), | ||
| + 0,0, | ||
| const_cast<void*>(value), | ||
| false); | ||
| return 0; | ||
| diff --git a/folly/portability/PThread.cpp b/folly/portability/PThread.cpp | ||
| index 2126ec0..ef82ade 100644 | ||
| --- a/folly/portability/PThread.cpp | ||
| +++ b/folly/portability/PThread.cpp | ||
| @@ -20,6 +20,8 @@ | ||
| #include <boost/thread/exceptions.hpp> | ||
| #include <boost/thread/tss.hpp> | ||
| #include <boost/version.hpp> | ||
| +#include <boost/shared_ptr.hpp> | ||
| +#include <boost/thread/thread_only.hpp> | ||
|
|
||
| #include <errno.h> | ||
|
|
||
| @@ -691,7 +693,7 @@ int pthread_setspecific(pthread_key_t key, const void* value) { | ||
| boost::detail::thread::cleanup_caller_t(), | ||
| boost::detail::thread::cleanup_func_t(), | ||
| #else | ||
| - boost::shared_ptr<boost::detail::tss_cleanup_function>(), | ||
| + 0,0, | ||
| #endif | ||
| const_cast<void*>(value), | ||
| false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,34 @@ | ||
| diff --git a/folly/portability/Windows.h b/folly/portability/Windows.h | ||
| index f7990ca..b22fac5 100644 | ||
| index 86fd0f9..ccad11e 100644 | ||
| --- a/folly/portability/Windows.h | ||
| +++ b/folly/portability/Windows.h | ||
| @@ -26,16 +26,12 @@ | ||
| // These have to be this way because we define our own versions | ||
| // of close(), because the normal Windows versions don't handle | ||
| // sockets at all. | ||
| @@ -32,24 +32,17 @@ | ||
| // disabled to ensure all of the normal names get declared properly. | ||
| #include <stdio.h> | ||
|
|
||
| -#ifndef __STDC__ | ||
| -/* nolint */ | ||
| -#define __STDC__ 1 | ||
| #pragma push_macro("_CRT_DECLARE_NONSTDC_NAMES") | ||
| #ifdef _CRT_DECLARE_NONSTDC_NAMES | ||
| #undef _CRT_DECLARE_NONSTDC_NAMES | ||
| #endif | ||
| + | ||
| +#include <corecrt.h> | ||
| #pragma push_macro("_CRT_INTERNAL_NONSTDC_NAMES") | ||
| -#undef _CRT_INTERNAL_NONSTDC_NAMES | ||
| -#include <direct.h> // @manual nolint | ||
| -#include <io.h> // @manual nolint | ||
| -#undef __STDC__ | ||
| +#define _CRT_INTERNAL_NONSTDC_NAMES 0 | ||
| +#include <direct.h> | ||
| +#include <io.h> | ||
| #pragma pop_macro("_CRT_INTERNAL_NONSTDC_NAMES") | ||
| -#pragma pop_macro("_CRT_DECLARE_NONSTDC_NAMES") | ||
| -#else | ||
| -#include <direct.h> // @manual nolint | ||
| -#include <io.h> // @manual nolint | ||
| -#endif | ||
| +#include <corecrt.h> | ||
| +#pragma push_macro("_CRT_INTERNAL_NONSTDC_NAMES") | ||
| +#define _CRT_INTERNAL_NONSTDC_NAMES 0 | ||
| +#include <direct.h> | ||
| +#include <io.h> | ||
| +#pragma pop_macro("_CRT_INTERNAL_NONSTDC_NAMES") | ||
|
|
||
| #if defined(min) || defined(max) | ||
| #error Windows.h needs to be included by this header, or else NOMINMAX needs \ | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: proxygen | ||
| Version: 2019.10.21.00 | ||
| Version: 2020.10.19.00 | ||
| Homepage: https://github.com/facebook/proxygen | ||
| Description: It comprises the core C++ HTTP abstractions used at Facebook. | ||
| Build-Depends: folly, fizz, wangle, zstd, zlib, openssl, boost-iostreams, boost-context, boost-date-time, boost-filesystem, boost-program-options, boost-regex, boost-system, boost-thread | ||
| Description: It comprises the core C++ HTTP abstractions used at Facebook. | ||
| Build-Depends: folly, fizz, wangle, zstd, zlib, openssl, boost-iostreams, boost-context, boost-date-time, boost-filesystem, boost-program-options, boost-regex, boost-system, boost-thread | ||
| Supports: !windows&!osx |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PhoebeHui , did you mean to add this line to the .patch? The resulting
portability/Windows.hhas a mismatched set ofpragma push/pop macrolines.Specifically, the resulting file contains
#pragma push_macro("_CRT_DECLARE_NONSTDC_NAMES")but no#pragma pop_macro("_CRT_DECLARE_NONSTDC_NAMES")