[folly/fizz/wangle/proxygen/fbthrift] Update to latest revision

[PhoebeHui]

Related to #13536

1. folly: remove 4 unused patches: find-double-conversion.patch fix-addbit.patch folly_c3861.patch fix-cmake-3.18.patch
2. folly: update 2 patches that match the source change in new revision.
3. folly: add fmt to 'Build-Depends'
4. proxygen: remove patch fix-tools-path.patch and use vcpkg_copy_tools instead.
5. fizz/wangle/proxygen/fbthrift need update togather.

All features test passed with x64-windows

[ras0219-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[PhoebeHui]

proxygen:x64-osx failures looks same issue with gperf issue http://savannah.gnu.org/bugs/?53028, which fix by http://git.savannah.gnu.org/gitweb/?p=gperf.git;a=commitdiff;h=baf89d87f0d94b83e7764569da9d84dd36f82ba9.

Confirmed this issue solved by installing gperf 3.1 on macos.

Failures:

gperf_case_memcmp (register const char *s1, register const char *s2, register unsigned int n)
                   ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:86:45: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
gperf_case_memcmp (register const char *s1, register const char *s2, register unsigned int n)
                                            ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:86:70: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
gperf_case_memcmp (register const char *s1, register const char *s2, register unsigned int n)
                                                                     ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:112:34: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
HTTPCommonHeadersInternal::hash (register const char *str, register unsigned int len)
                                 ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:112:60: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
HTTPCommonHeadersInternal::hash (register const char *str, register unsigned int len)
                                                           ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:143:3: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
  register unsigned int hval = len;
  ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:302:41: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
HTTPCommonHeadersInternal::in_word_set (register const char *str, register unsigned int len)
                                        ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:302:67: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
HTTPCommonHeadersInternal::in_word_set (register const char *str, register unsigned int len)
                                                                  ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:310:11: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
          register int index = lookup[key];
          ^~~~~~~~~
generated/proxygen/lib/http/HTTPCommonHeaders.cpp:316:19: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
                  register const char *s = wordlist[index].name;
                  ^~~~~~~~~
10 errors generated.

[PhoebeHui]

Disable proxygen:x64-osx temporarily for unblocking this PR, and will enable it when PR #14228 merged.

[BillyONeal]

Thanks for your contribution!

[dubois]

Hi @PhoebeHui , did you mean to add this line to the .patch? The resulting portability/Windows.h has a mismatched set of pragma push/pop macro lines.

Specifically, the resulting file contains #pragma push_macro("_CRT_DECLARE_NONSTDC_NAMES") but no #pragma pop_macro("_CRT_DECLARE_NONSTDC_NAMES")