[many ports] Add more KF5 frameworks#13469
Closed
wrobelda wants to merge 161 commits intomicrosoft:masterfrom
Closed
[many ports] Add more KF5 frameworks#13469wrobelda wants to merge 161 commits intomicrosoft:masterfrom
wrobelda wants to merge 161 commits intomicrosoft:masterfrom
Conversation
kf5crash - make x11 patch exclusive to linux - enable win/macOS builds kf5syntaxhighlighting - fix building on non-Win by removing the cli tool from all platforms
This reverts commit 8703c24.
This reverts commit f1ac3db.
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Contributor
|
Hi @wrobelda Could you please spilt these changes in this PR into several PRs? Since there are a large amount of files here, which is more difficult to review. You can add 2 new ports in one PR. |
Contributor
Author
@NancyLi1013 Can do. However, all these depend on the other PR (#13467) so I would appreciate if you could review and hopefully merge that one first. |
Contributor
|
Thanks for your kindly reminder. |
# Conflicts: # ports/qt5-base/portfile.cmake
NancyLi1013
added
the
depends:different-pr
Contributor
Author
|
As requested by @NancyLi1013, I will create separate PRs for these ports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ports for a whole bunch more KDE Frameworks
Which triplets are supported/not supported? Have you updated the CI baseline?
All default triplets should be supported
Does your PR follow the maintainer guide?
Yes, except the requirement to publish the ports separately. However, these ports are for the most part a copy-and-paste, with some exceptions.