Skip to content

[gtest] Fix installed cmake file path#12997

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/re-fix-gtest-cmake-path
Aug 20, 2020
Merged

[gtest] Fix installed cmake file path#12997
BillyONeal merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/re-fix-gtest-cmake-path

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Aug 19, 2020

gtest generated GTestConfig.cmake, GTestConfigVersion.cmake etc.
Fix their installed path.

Related: #12604

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 19, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui August 20, 2020 02:06
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 20, 2020
@BillyONeal BillyONeal merged commit 0d52f66 into microsoft:master Aug 20, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your contribution!

@JackBoosY JackBoosY deleted the dev/jack/re-fix-gtest-cmake-path branch August 20, 2020 02:51
@cenit
Copy link
Copy Markdown
Contributor

cenit commented Aug 20, 2020

CMake is case sensitive for file names (GTestConfig.cmake is different from gtestConfig.cmake) but not for folder names. So this Pr and #12604 are unnecessary

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@cenit they are necessary, Because vcpkg sets ${PORT_NAME}_DIR to cmake to find these cmake files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants