[vcpkg postcheck] Check the folder name of the generated cmake file by JackBoosY · Pull Request #12604 · microsoft/vcpkg

JackBoosY · 2020-07-28T00:47:45Z

Since find_package is case-sensitive in *nix, check after the build whether the name of the generated cmake file matches the name of the folder where it is located.

…jack/check_cmake_file_directory

strega-nil

I see some changes that need to be done so that it follows the style of vcpkg, and also some better ways to do the things (using Strings::ends_with instead of .find, for example). Additionally, we need to use fs::u8string instead of .string(), to avoid locale-specificity.

strega-nil · 2020-08-12T17:22:27Z

@JackBoosY could you do the suggestions?

…jack/check_cmake_file_directory

JackBoosY · 2020-08-13T09:07:00Z

@strega-nil Sorry, I forgot it. Done.

strega-nil · 2020-08-14T17:17:39Z

Hrmm, now that I'm looking at this, this check seems wrong? Check out the find_package documentation:

In all cases the <name> is treated as case-insensitive and corresponds to any of the names specified (<PackageName> or names given by NAMES).

JackBoosY · 2020-08-18T02:05:28Z

@strega-nil Sadly, it does affect us to get the correct *-config.cmake.
See #12592 changes.
vcpkg sets the search path SEARCHNAME_DIR to installed/TRIPLET/share/PORT_NAME, so that find_package can find the correct cmake file under this path, and PORT_NAME is case sensitive in Linux.

BillyONeal · 2020-08-18T23:39:24Z

This doesn't build cleanly anymore due to the u8path thing.

JackBoosY · 2020-08-19T03:12:22Z

@BillyONeal More details?

…e_file_directory

BillyONeal · 2020-08-20T04:25:44Z

I assume the Arrow 'regression' is what you are trying to look for? :)

BillyONeal · 2020-08-20T04:27:11Z

+                auto filename = fs::u8string(file_path.filename());
+                if (Strings::ends_with(filename, UPPER_CONFIG))
+                {
+                    config_prefix = filename.substr(0, filename.size() - UPPER_CONFIG.size());


Should we also check for "CoNFiG.cmAkE" (And possibly fail the results if any such things are present?)

Nope, generally, the file names generated by cmake are fixed.

BillyONeal · 2020-08-20T04:27:37Z

+                               cmake_file.filename().string().c_str(),
+                               cmake_file.parent_path().string().c_str(),


These probably need to use some form of u8something rather than string()

ras0219 · 2020-08-20T21:59:16Z

vcpkg sets the search path SEARCHNAME_DIR to installed/TRIPLET/share/PORT_NAME

Can you link where this happens?

strega-nil

I would like to see the bug this fixes.

JackBoosY · 2020-08-21T02:25:43Z

@ras0219 Maybe I misunderstood this point, but it did cause some problems.

JackBoosY · 2020-08-21T02:26:47Z

@strega-nil Example #12997 #12592 etc.

JackBoosY · 2020-08-21T06:29:45Z

According to the official document, I think this PR is no longer needed.
We only need to ensure that the folder name is lowercase (already do that).

[vcpkg] Check the folder name of the generated cmake file

43f13c6

JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal labels Jul 28, 2020

JackBoosY requested a review from strega-nil July 28, 2020 00:47

JackBoosY assigned PhoebeHui Jul 28, 2020

JackBoosY changed the title ~~[vcpkg] Check the folder name of the generated cmake file~~ [vcpkg postcheck] Check the folder name of the generated cmake file Jul 28, 2020

JackBoosY added 5 commits July 27, 2020 19:24

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

c0044c8

…jack/check_cmake_file_directory

fix build error on linux

a270ebb

Remove Find*.cmake check

6593664

[rapidjson] Correct cmake file path

c1d3bdc

update portfile.cmake

23e9932

JackBoosY marked this pull request as ready for review August 5, 2020 02:50

JackBoosY requested a review from PhoebeHui August 10, 2020 02:37

Fix cmakePrefix position when generated *-config.cmake

03ac5e3

PhoebeHui approved these changes Aug 10, 2020

View reviewed changes

JackBoosY and others added 3 commits August 9, 2020 22:40

[arrow] Correct cmake file path

29b0ce9

Merge branch 'master' into dev/jack/check_cmake_file_directory

2d6622b

[arrow] Revert changes

11163c5

PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 10, 2020

strega-nil suggested changes Aug 10, 2020

View reviewed changes

JackBoosY added 2 commits August 13, 2020 02:02

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

0115fa3

…jack/check_cmake_file_directory

use suggestions.

aa92571

Correct substring.

1a169df

BillyONeal added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Aug 18, 2020

JackBoosY mentioned this pull request Aug 20, 2020

[gtest] Fix installed cmake file path #12997

Merged

BillyONeal added 2 commits August 19, 2020 19:20

Merge remote-tracking branch 'origin/master' into dev/jack/check_cmak…

89d39c8

…e_file_directory

Fix build failure.

d0a0ea0

BillyONeal requested a review from strega-nil August 20, 2020 04:25

BillyONeal removed the requires:author-response label Aug 20, 2020

BillyONeal reviewed Aug 20, 2020

View reviewed changes

BillyONeal added requires:discussion and removed requires:discussion labels Aug 20, 2020

strega-nil suggested changes Aug 20, 2020

View reviewed changes

JackBoosY closed this Aug 21, 2020

		cmake_file.filename().string().c_str(),
		cmake_file.parent_path().string().c_str(),

Conversation

JackBoosY commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

strega-nil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil commented Aug 12, 2020

Uh oh!

JackBoosY commented Aug 13, 2020

Uh oh!

strega-nil commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Aug 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal commented Aug 18, 2020

Uh oh!

JackBoosY commented Aug 19, 2020

Uh oh!

BillyONeal commented Aug 20, 2020

Uh oh!

BillyONeal Aug 20, 2020

Choose a reason for hiding this comment

Uh oh!

JackBoosY Aug 20, 2020

Choose a reason for hiding this comment

Uh oh!

BillyONeal Aug 20, 2020

Choose a reason for hiding this comment

Uh oh!

ras0219 commented Aug 20, 2020

Uh oh!

strega-nil left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Aug 21, 2020

Uh oh!

JackBoosY commented Aug 21, 2020

Uh oh!

JackBoosY commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JackBoosY commented Jul 28, 2020 •

edited

Loading

strega-nil commented Aug 14, 2020 •

edited

Loading

JackBoosY commented Aug 18, 2020 •

edited

Loading

JackBoosY commented Aug 21, 2020 •

edited

Loading