[VCPKG baseline][libmicrohttpd] Change the installed header file path#12445
Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
Closed
[VCPKG baseline][libmicrohttpd] Change the installed header file path#12445JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-bug
PhoebeHui
approved these changes
Jul 16, 2020
Contributor
|
Duplicated to PR #12455 |
ras0219-msft
requested changes
Jul 17, 2020
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
I think this is superceded by #12455
| file(GLOB MICROHTTPD_HEADERS ${SOURCE_PATH}/src/include/*h) | ||
| foreach(MICROHTTPD_HEADER ${MICROHTTPD_HEADERS}) | ||
| file(COPY ${MICROHTTPD_HEADER} DESTINATION ${CURRENT_PACKAGES_DIR}/include) | ||
| file(COPY ${MICROHTTPD_HEADER} DESTINATION ${CURRENT_PACKAGES_DIR}/include/libmicrohttpd) |
Contributor
There was a problem hiding this comment.
Moving the headers into a subfolder would break all existing users; it turns out that the problematic headers are not intended for installation, so the better solution is to simply not install those.
See #12455
| @@ -1,4 +1,5 @@ | |||
| Source: nrf-ble-driver | |||
| Version: 4.1.2 | |||
| Port-Version: 1 | |||
Contributor
There was a problem hiding this comment.
Due to changes in the CI system, we no longer need to trigger rebuilds of failed ports this way.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some header files in
nrf-ble-driverincludeplatform.h, and this file exists in bothnrf-ble-driverandlibmicrohttpd. This leads to abnormal usage.Change the installed header file path to include/libmicrohttpd to avoid file conflicts with
nrf-ble-driver.Related: #12434 #12084 #11208 #11208 #12342 etc.