Build fix with MinGW GCC 9.2.0#12084
Merged
strega-nil merged 4 commits intomicrosoft:masterfrom Jul 18, 2020
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
approved these changes
Jun 28, 2020
JackBoosY
added
category:vcpkg-bug
strega-nil
approved these changes
Jul 15, 2020
Contributor
strega-nil
left a comment
strega-nil
left a comment
There was a problem hiding this comment.
Can you merge to latest master? This seems like something we definitely want.
ras0219-msft
approved these changes
Jul 15, 2020
Contributor
Author
I've rebased on master. |
read_symlink_implementation was used only in copy_symlink_implementation when #if defined(_WIN32) && !VCPKG_USE_STD_FILESYSTEM was true. Removed the warning otherwise.
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jul 19, 2020
Build fix with MinGW GCC 9.2.0 (microsoft#12084)
remz1337
pushed a commit
to remz1337/vcpkg
that referenced
this pull request
Aug 11, 2020
* Build fix with MinGW GCC 9.2.0 * Fix MinGW tripplets Fixes microsoft#12065 * clang-format * Fix unused read_symlink_implementation warning marked as error read_symlink_implementation was used only in copy_symlink_implementation when #if defined(_WIN32) && !VCPKG_USE_STD_FILESYSTEM was true. Removed the warning otherwise. Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* Build fix with MinGW GCC 9.2.0 * Fix MinGW tripplets Fixes microsoft#12065 * clang-format * Fix unused read_symlink_implementation warning marked as error read_symlink_implementation was used only in copy_symlink_implementation when #if defined(_WIN32) && !VCPKG_USE_STD_FILESYSTEM was true. Removed the warning otherwise. Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR will allow building vcpkg itself with MinGW GCC 9.2.0. It fixes some warnings and because warnings are treated as errors, the build would fail.
It also fixes the usage of MinGW community tripplets.
Fixes: #12065