add feature build vtk[qtopengl] by jafrado · Pull Request #10060 · microsoft/vcpkg

jafrado · 2020-02-13T22:35:10Z

Describe the pull request

What does your PR fix? Fixes issue [<vtk>] build failure with QTOpenGLWidget #10027
[<vtk>] build failure with QTOpenGLWidget #10027
Which triplets are supported/not supported?
None
Have you updated the CI baseline?
Yes
Does your PR follow the maintainer guide?
Yes

msftclas · 2020-02-13T22:35:22Z

All CLA requirements met.

jafrado · 2020-02-13T22:36:18Z

@NancyLi1013 - fix for this issue.

LilyWangL · 2020-02-14T09:33:53Z

/azp run

ports/vtk/CONTROL

Neumann-A · 2020-02-14T11:48:29Z

ports/vtk/CONTROL

+
+Feature: qtopengl
+Description: OpenGL with Qt for vtk on Windows
+Build-Depends: qt5


don't add all of qt5. You probably only need qt5-base

also you can depend on vtk[core,qt5]

Good call, this will reduce the build time substantially, however, it also needs qt5-tools,
(if you only include qt5-base, it fails as below):

CMake Error at C:/src/vcpkg/work/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package): Could not find a package configuration file provided by "Qt5UiPlugin" with any of the following names: Qt5UiPluginConfig.cmake qt5uiplugin-config.cmake Add the installation prefix of "Qt5UiPlugin" to CMAKE_PREFIX_PATH or set "Qt5UiPlugin_DIR" to a directory containing one of the above files. If "Qt5UiPlugin" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): C:/src/vcpkg/work/vcpkg/installed/x86-windows/share/cmake/Qt5/Qt5Config.cmake:28 (find_package) C:/src/vcpkg/work/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package) GUISupport/Qt/CMakeLists.txt:128 (find_package)

Note that this has the effect of also bringing in:

* qt5-activeqt[core]:x64-windows * qt5-base[core]:x64-windows * qt5-declarative[core]:x64-windows * qt5-imageformats[core]:x64-windows * qt5-svg[core]:x64-windows

Which is still better than the whole Qt5 package!

ports/vtk/portfile.cmake

Merge branch 'master' of https://github.com/microsoft/vcpkg

jafrado

Will resubmit new change set.

ports/vtk/CONTROL

jafrado · 2020-02-14T23:20:48Z

ports/vtk/CONTROL

+
+Feature: qtopengl
+Description: OpenGL with Qt for vtk on Windows
+Build-Depends: qt5


Good call, this will reduce the build time substantially, however, it also needs qt5-tools,
(if you only include qt5-base, it fails as below):

CMake Error at C:/src/vcpkg/work/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package): Could not find a package configuration file provided by "Qt5UiPlugin" with any of the following names: Qt5UiPluginConfig.cmake qt5uiplugin-config.cmake Add the installation prefix of "Qt5UiPlugin" to CMAKE_PREFIX_PATH or set "Qt5UiPlugin_DIR" to a directory containing one of the above files. If "Qt5UiPlugin" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): C:/src/vcpkg/work/vcpkg/installed/x86-windows/share/cmake/Qt5/Qt5Config.cmake:28 (find_package) C:/src/vcpkg/work/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package) GUISupport/Qt/CMakeLists.txt:128 (find_package)

Note that this has the effect of also bringing in:

* qt5-activeqt[core]:x64-windows * qt5-base[core]:x64-windows * qt5-declarative[core]:x64-windows * qt5-imageformats[core]:x64-windows * qt5-svg[core]:x64-windows

Which is still better than the whole Qt5 package!

ports/vtk/portfile.cmake

jafrado · 2020-02-17T19:26:54Z

Not sure how to fix the above pipeline checks ... or even if they are related.

LilyWangL · 2020-03-04T10:51:21Z

/azp run

LilyWangL · 2020-03-04T12:34:24Z

@jafrado Thanks for your PR. Current this port build failed with the following error, could you please continue to fix it?

CMake Error at C:/vsts/_work/3/s/scripts/buildsystems/vcpkg.cmake:288 (_find_package):
  By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5", but
  CMake did not find one.

  Could not find a package configuration file provided by "Qt5" with any of
  the following names:

    Qt5Config.cmake
    qt5-config.cmake

  Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
  to a directory containing one of the above files.  If "Qt5" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  GUISupport/Qt/CMakeLists.txt:71 (find_package)

jafrado · 2020-03-04T20:09:03Z

@LilyWangL - thanks, did you run this patch-set: 993267b

The error you see should not be present, since the lines:

Build-Depends: qt5-base, qt5-tools, vtk[core]

include qt5-tools which has the qt5-config.cmake

Let me know and I can repost the original patch.

LilyWangL · 2020-03-05T07:27:40Z

I cloned your latest commit and reproduced the CI test error. Due to -DModule_vtkGUISupportQt=ON, vtk build failed with this error:

CMake Error at C:/vsts/_work/3/s/scripts/buildsystems/vcpkg.cmake:288 (_find_package):
  By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5", but
  CMake did not find one.

  Could not find a package configuration file provided by "Qt5" with any of
  the following names:

    Qt5Config.cmake
    qt5-config.cmake

  Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
  to a directory containing one of the above files.  If "Qt5" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  GUISupport/Qt/CMakeLists.txt:71 (find_package)

This error appear when cmake vtk/src/v8.2.0-d1dd9405dd/GUISupport/Qt/CMakeLists.txt Line71.

jafrado · 2020-03-05T19:36:58Z

@LilyWangL - thanks, I will check it out.

princetonpku · 2020-03-21T05:49:02Z

I try the new port.cmake and isntall use following:
vcpkg install vtk[qt,qtopengl]:x64-windows

Howerver, the "vtkQtLabelRenderStrategy.h" is not installed. Is any solution for this?

JackBoosY · 2020-03-26T05:37:57Z

/azp run

jafrado · 2020-03-27T04:28:38Z

This is really weird. This works for me and I have it checked in to my repo for some time now.
Can you send me the build error?

JackBoosY · 2020-03-27T05:49:09Z

Rerun test maually, I will give you failure log later.

JackBoosY · 2020-03-27T06:55:37Z

...
-- Found Eigen3: G:/10060/vcpkg/installed/x86-windows/include/eigen3 (Required is at least version "2.91.0") 
-- Found ZLIB: optimized;G:/10060/vcpkg/installed/x86-windows/lib/zlib.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/zlibd.lib (found version "1.2.11") 
-- Found Freetype: optimized;G:/10060/vcpkg/installed/x86-windows/lib/freetype.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/freetyped.lib (found version "2.10.1") 
-- Found double-conversion: G:/10060/vcpkg/installed/x86-windows/include/double-conversion  
-- Found LZ4: optimized;G:/10060/vcpkg/installed/x86-windows/lib/lz4.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/lz4d.lib  
-- Found LZMA: optimized;G:/10060/vcpkg/installed/x86-windows/lib/lzma.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/lzmad.lib  
-- Found EXPAT: G:/10060/vcpkg/installed/x86-windows/lib/expat.lib (found version "2.2.7") 
-- Found OpenGL: opengl32   
CMake Error at G:/10060/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package):
  By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5", but
  CMake did not find one.

  Could not find a package configuration file provided by "Qt5" with any of
  the following names:

    Qt5Config.cmake
    qt5-config.cmake

  Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
  to a directory containing one of the above files.  If "Qt5" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  GUISupport/Qt/CMakeLists.txt:71 (find_package)


-- Configuring incomplete, errors occurred!

jafrado · 2020-03-27T07:14:02Z

Thanks, will check it out tomorrow.

jafrado · 2020-03-27T19:51:05Z

Yep, broken. Hang on, lets go back to basics ...

…

On Thu, Mar 26, 2020 at 11:55 PM Jack·Boos·Yu ***@***.***> wrote: ... -- Found Eigen3: G:/10060/vcpkg/installed/x86-windows/include/eigen3 (Required is at least version "2.91.0") -- Found ZLIB: optimized;G:/10060/vcpkg/installed/x86-windows/lib/zlib.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/zlibd.lib (found version "1.2.11") -- Found Freetype: optimized;G:/10060/vcpkg/installed/x86-windows/lib/freetype.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/freetyped.lib (found version "2.10.1") -- Found double-conversion: G:/10060/vcpkg/installed/x86-windows/include/double-conversion -- Found LZ4: optimized;G:/10060/vcpkg/installed/x86-windows/lib/lz4.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/lz4d.lib -- Found LZMA: optimized;G:/10060/vcpkg/installed/x86-windows/lib/lzma.lib;debug;G:/10060/vcpkg/installed/x86-windows/debug/lib/lzmad.lib -- Found EXPAT: G:/10060/vcpkg/installed/x86-windows/lib/expat.lib (found version "2.2.7") -- Found OpenGL: opengl32 CMake Error at G:/10060/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package): By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Qt5", but CMake did not find one. Could not find a package configuration file provided by "Qt5" with any of the following names: Qt5Config.cmake qt5-config.cmake Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR" to a directory containing one of the above files. If "Qt5" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): GUISupport/Qt/CMakeLists.txt:71 (find_package) -- Configuring incomplete, errors occurred! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10060 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXSUDFENXJLTZP4KXMU4OTRJREXNANCNFSM4KU4LT7A> .

jafrado · 2020-03-27T20:37:28Z

Ok, lets try listing qt5-tools first to pickup Qt5Config.cmake, qt5-config.cmake before qtbase, otherwise we can just list the whole qt5 package as a dependency (which is what we have checked in to make a working software where I am working right now).

See if this change works:
3f99253

jafrado · 2020-04-16T17:05:14Z

Let me know how to check/resolve this one. The patches I provided work here locally for me. I guess I need to know how to run your pre-commit

JackBoosY · 2020-05-08T04:54:22Z

Any progress?

jafrado · 2020-05-09T17:32:41Z

Thanks, will take a look this week. Can you send a link to your CI setup/test docs?

…

On Thu, May 7, 2020 at 9:54 PM Jack·Boos·Yu ***@***.***> wrote: Any progress? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10060 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXSUDBEN3UGCDAFCLVMCOTRQOGAVANCNFSM4KU4LT7A> .

Neumann-A · 2020-05-09T18:15:47Z

@jafrado he is probably asking because #11148 is updating VTK to 9.0

JackBoosY · 2020-05-11T02:37:19Z

/azp run

azure-pipelines · 2020-05-11T02:37:28Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-05-11T09:26:33Z

x64-linux regression(vtk):

CMake Error at /mnt/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package):
  Could not find a package configuration file provided by "Qt5X11Extras" with
  any of the following names:

    Qt5X11ExtrasConfig.cmake
    qt5x11extras-config.cmake

  Add the installation prefix of "Qt5X11Extras" to CMAKE_PREFIX_PATH or set
  "Qt5X11Extras_DIR" to a directory containing one of the above files.  If
  "Qt5X11Extras" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  /mnt/1/s/installed/x64-linux/share/cmake/Qt5/Qt5Config.cmake:28 (find_package)
  /mnt/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  GUISupport/Qt/CMakeLists.txt:71 (find_package)

x64-osx regression(pcl):

CMake Error at /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Core/Qt5CoreConfig.cmake:113 (message):
  Library not found: m
Call Stack (most recent call first):
  /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Core/Qt5CoreConfig.cmake:195 (_qt5_Core_parse_prl)
  /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Core/Qt5CoreConfig.cmake:317 (_populate_Core_target_properties)
  /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Gui/Qt5GuiConfig.cmake:255 (find_package)
  /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:255 (find_package)
  /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5/Qt5Config.cmake:28 (find_package)
  /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  /Volumes/data/work/1/s/installed/x64-osx/share/vtk/Modules/vtkGUISupportQt.cmake:19 (find_package)
  /Volumes/data/work/1/s/installed/x64-osx/share/vtk/vtkModuleAPI.cmake:45 (include)
  /Volumes/data/work/1/s/installed/x64-osx/share/vtk/vtkModuleAPI.cmake:15 (vtk_module_load)
  /Volumes/data/work/1/s/installed/x64-osx/share/vtk/vtkModuleAPI.cmake:152 (_vtk_module_config_recurse)
  /Volumes/data/work/1/s/installed/x64-osx/share/vtk/VTKConfig.cmake:137 (vtk_module_config)
  /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  CMakeLists.txt:364 (find_package)

jafrado · 2020-05-11T19:59:42Z

My core development platform is Linux and I don't have that error. If there is something I can read to try to debug your Azure pipeline let me know. Otherwise, I will wait for you to update to VTK 9 and then retest and see if it works.

…

On Mon, May 11, 2020 at 2:26 AM Jack·Boos·Yu ***@***.***> wrote: x64-linux regression(vtk): CMake Error at /mnt/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package): Could not find a package configuration file provided by "Qt5X11Extras" with any of the following names: Qt5X11ExtrasConfig.cmake qt5x11extras-config.cmake Add the installation prefix of "Qt5X11Extras" to CMAKE_PREFIX_PATH or set "Qt5X11Extras_DIR" to a directory containing one of the above files. If "Qt5X11Extras" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): /mnt/1/s/installed/x64-linux/share/cmake/Qt5/Qt5Config.cmake:28 (find_package) /mnt/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package) GUISupport/Qt/CMakeLists.txt:71 (find_package) x64-osx regression(pcl): CMake Error at /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Core/Qt5CoreConfig.cmake:113 (message): Library not found: m Call Stack (most recent call first): /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Core/Qt5CoreConfig.cmake:195 (_qt5_Core_parse_prl) /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Core/Qt5CoreConfig.cmake:317 (_populate_Core_target_properties) /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package) /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Gui/Qt5GuiConfig.cmake:255 (find_package) /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package) /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:255 (find_package) /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package) /Volumes/data/work/1/s/installed/x64-osx/share/cmake/Qt5/Qt5Config.cmake:28 (find_package) /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package) /Volumes/data/work/1/s/installed/x64-osx/share/vtk/Modules/vtkGUISupportQt.cmake:19 (find_package) /Volumes/data/work/1/s/installed/x64-osx/share/vtk/vtkModuleAPI.cmake:45 (include) /Volumes/data/work/1/s/installed/x64-osx/share/vtk/vtkModuleAPI.cmake:15 (vtk_module_load) /Volumes/data/work/1/s/installed/x64-osx/share/vtk/vtkModuleAPI.cmake:152 (_vtk_module_config_recurse) /Volumes/data/work/1/s/installed/x64-osx/share/vtk/VTKConfig.cmake:137 (vtk_module_config) /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:329 (_find_package) CMakeLists.txt:364 (find_package) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10060 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXSUDBLFI6MQXBY655F2N3RQ7AFTANCNFSM4KU4LT7A> .

JackBoosY · 2020-05-12T03:17:42Z

@jafrado Please get full logs here.

jafrado · 2020-05-12T03:19:20Z

Thanks, I saw that, I'm trying to recreate the issue. Not just spam the problem with run after run of commits. Is there a way to recreate or test changes in the CI environment?

…

On Mon, May 11, 2020 at 8:17 PM Jack·Boos·Yu ***@***.***> wrote: @jafrado <https://github.com/jafrado> Please get full logs here <https://dev.azure.com/vcpkg/public/_build/results?buildId=36597&view=artifacts&type=publishedArtifacts> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10060 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXSUDD7BBTWD3GHMGJT67TRRC5WFANCNFSM4KU4LT7A> .

jafrado · 2020-05-12T03:21:22Z

Can you try to install this in your CI environment? CMake Warning at ports/vtk/portfile.cmake:2 (message): You will need to install Xorg dependencies to build vtk: apt-get install libxt-dev Call Stack (most recent call first): scripts/ports.cmake:90 (include)

…

On Mon, May 11, 2020 at 8:19 PM James Dougherty ***@***.***> wrote: Thanks, I saw that, I'm trying to recreate the issue. Not just spam the problem with run after run of commits. Is there a way to recreate or test changes in the CI environment? On Mon, May 11, 2020 at 8:17 PM Jack·Boos·Yu ***@***.***> wrote: > @jafrado <https://github.com/jafrado> Please get full logs here > <https://dev.azure.com/vcpkg/public/_build/results?buildId=36597&view=artifacts&type=publishedArtifacts> > . > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#10060 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACXSUDD7BBTWD3GHMGJT67TRRC5WFANCNFSM4KU4LT7A> > . >

ports/vtk/CONTROL

# Conflicts: # ports/vtk/CONTROL # ports/vtk/portfile.cmake

jafrado · 2020-05-12T16:09:39Z

I just pulled the latest master, it looks like it includes QtOpenGL support and VTK 9.0 Let me test it out this week - more later.

…

On Mon, May 11, 2020 at 11:04 PM Jack·Boos·Yu ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In ports/vtk/CONTROL <#10060 (comment)>: > @@ -2,7 +2,7 @@ Source: vtk Version: 8.2.0-12 Description: Software system for 3D computer graphics, image processing, and visualization Homepage: https://github.com/Kitware/VTK -Build-Depends: zlib, libpng, tiff, libxml2, jsoncpp, glew, freetype, expat, hdf5, libjpeg-turbo, proj4, lz4, libtheora, eigen3, double-conversion, pugixml, libharu, sqlite3, netcdf-c +Build-Depends: zlib, libpng, tiff, libxml2, jsoncpp, glew, freetype, expat, hdf5, libjpeg-turbo, proj4, lz4, libtheora, eigen3, double-conversion, pugixml, libharu, sqlite3, netcdf-c, qt5 ⬇️ Suggested change -Build-Depends: zlib, libpng, tiff, libxml2, jsoncpp, glew, freetype, expat, hdf5, libjpeg-turbo, proj4, lz4, libtheora, eigen3, double-conversion, pugixml, libharu, sqlite3, netcdf-c, qt5 +Build-Depends: zlib, libpng, tiff, libxml2, jsoncpp, glew, freetype, expat, hdf5, libjpeg-turbo, proj4, lz4, libtheora, eigen3, double-conversion, pugixml, libharu, sqlite3, netcdf-c ------------------------------ In ports/vtk/CONTROL <#10060 (comment)>: > @@ -2,7 +2,7 @@ Source: vtk Version: 8.2.0-12 ⬇️ Suggested change -Version: 8.2.0-12 +Version: 8.2.0-13 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10060 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXSUDHW47XJNMCQHLELO63RRDRFRANCNFSM4KU4LT7A> .

JackBoosY · 2020-05-13T02:10:45Z

CMake Error at /home/vzay/work/10060/vcpkg/scripts/buildsystems/vcpkg.cmake:286 (_find_package):
  Could not find a package configuration file provided by "Qt5X11Extras" with
  any of the following names:

    Qt5X11ExtrasConfig.cmake
    qt5x11extras-config.cmake

  Add the installation prefix of "Qt5X11Extras" to CMAKE_PREFIX_PATH or set
  "Qt5X11Extras_DIR" to a directory containing one of the above files.  If
  "Qt5X11Extras" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  /home/vzay/work/10060/vcpkg/installed/x64-linux/share/cmake/Qt5/Qt5Config.cmake:28 (find_package)
  /home/vzay/work/10060/vcpkg/scripts/buildsystems/vcpkg.cmake:286 (_find_package)
  GUISupport/Qt/CMakeLists.txt:71 (find_package)

ports/vtk/CONTROL

JackBoosY · 2020-06-16T09:00:24Z

ports/vtk/portfile.cmake

 endif()

 if("paraview" IN_LIST FEATURES)
+if(VTK_WITH_QT_OPENGL)


Where this value is not set, I think it is always 0.

BillyONeal · 2020-07-09T22:00:55Z

If this was waiting for a VM change that might have been done now in support of the Qt update change merged recently.

Neumann-A · 2020-07-10T12:01:58Z

@JackBoosY @BillyONeal: This PR can probably be closed due to the update to VTK 9 which includes opengl feature.

if("opengl" IN_LIST FEATURES)
    list(APPEND ADDITIONAL_OPTIONS
        -DVTK_MODULE_ENABLE_VTK_DomainsChemestryOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_ImagingOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_RenderingContextOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_RenderingGL2PSOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_RenderingLICOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_RenderingOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_RenderingVolumeOpenGL2=YES
        -DVTK_MODULE_ENABLE_VTK_opengl=YES
        )
endif()

if("qt" IN_LIST FEATURES)
    list(APPEND ADDITIONAL_OPTIONS
        -DVTK_GROUP_ENABLE_Qt=YES
        -DVTK_MODULE_ENABLE_VTK_GUISupportQt=YES
        -DVTK_MODULE_ENABLE_VTK_GUISupportQtSQL=YES
        -DVTK_MODULE_ENABLE_VTK_RenderingQt=YES
        -DVTK_MODULE_ENABLE_VTK_ViewsQt=YES
    )
endif()

jafrado · 2020-07-10T15:06:20Z

Yes. Please close. Thank you all very much for your support!

# Updates: # ports/vtk/CONTROL # ports/vtk/portfile.cmake

# Updates: # ports/vtk/portfile.cmake

jafrado · 2020-07-10T15:32:58Z

Please disregard last commit. Thanks again!

JackBoosY · 2020-07-13T02:12:22Z

Thanks for this PR!

add feature build vtk[qtopengl]

80c3357

jafrado mentioned this pull request Feb 13, 2020

[<vtk>] build failure with QTOpenGLWidget #10027

Closed

LilyWangL self-assigned this Feb 14, 2020

Neumann-A reviewed Feb 14, 2020

View reviewed changes

ports/vtk/CONTROL Outdated Show resolved Hide resolved

Neumann-A reviewed Feb 14, 2020

View reviewed changes

ports/vtk/portfile.cmake Show resolved Hide resolved

synch upstream

ae8c35a

Merge branch 'master' of https://github.com/microsoft/vcpkg

jafrado commented Feb 14, 2020

View reviewed changes

fixes after codereview with @Neumann-A

993267b

LilyWangL added the needs-feature-review label Mar 12, 2020

jfd added 3 commits March 27, 2020 12:51

initial working version for QVTKOpenGLWidget

415ac9e

Merge branch 'master' of https://github.com/microsoft/vcpkg

d139898

list qt5-tools first for qtopengl

3f99253

jfd added 2 commits April 13, 2020 13:08

Merge branch 'master' of https://github.com/microsoft/vcpkg

8bbe5c2

take 3

8a01ba8

JackBoosY suggested changes May 12, 2020

View reviewed changes

ports/vtk/CONTROL Outdated Show resolved Hide resolved

ports/vtk/CONTROL Outdated Show resolved Hide resolved

Merge branch 'master' of https://github.com/microsoft/vcpkg

70a3d8d

# Conflicts: # ports/vtk/CONTROL # ports/vtk/portfile.cmake

JackBoosY reviewed May 13, 2020

View reviewed changes

ports/vtk/CONTROL Show resolved Hide resolved

strega-nil added requires:discussion and removed legacy:needs-feature-review labels May 21, 2020

LilyWangL assigned JackBoosY Jun 16, 2020

JackBoosY suggested changes Jun 16, 2020

View reviewed changes

jfd added 2 commits July 10, 2020 08:10

Merge branch 'master' of https://github.com/microsoft/vcpkg

c0f14ee

# Updates: # ports/vtk/CONTROL # ports/vtk/portfile.cmake

Merge branch 'master' of https://github.com/jafrado/vcpkg

fea56f7

# Updates: # ports/vtk/portfile.cmake

JackBoosY closed this Jul 13, 2020

Conversation

jafrado commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jafrado commented Feb 13, 2020

Uh oh!

LilyWangL commented Feb 14, 2020

Uh oh!

Uh oh!

Neumann-A Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

Neumann-A Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

jafrado Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jafrado left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jafrado Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jafrado commented Feb 17, 2020

Uh oh!

LilyWangL commented Mar 4, 2020

Uh oh!

LilyWangL commented Mar 4, 2020

Uh oh!

jafrado commented Mar 4, 2020

Uh oh!

LilyWangL commented Mar 5, 2020

Uh oh!

jafrado commented Mar 5, 2020

Uh oh!

princetonpku commented Mar 21, 2020

Uh oh!

JackBoosY commented Mar 26, 2020

Uh oh!

jafrado commented Mar 27, 2020

Uh oh!

JackBoosY commented Mar 27, 2020

Uh oh!

JackBoosY commented Mar 27, 2020

Uh oh!

jafrado commented Mar 27, 2020

Uh oh!

jafrado commented Mar 27, 2020 via email

Uh oh!

jafrado commented Mar 27, 2020

Uh oh!

jafrado commented Apr 16, 2020

Uh oh!

JackBoosY commented May 8, 2020

Uh oh!

jafrado commented May 9, 2020 via email

Uh oh!

Neumann-A commented May 9, 2020

Uh oh!

JackBoosY commented May 11, 2020

Uh oh!

azure-pipelines bot commented May 11, 2020

Uh oh!

JackBoosY commented May 11, 2020

Uh oh!

jafrado commented May 11, 2020 via email

Uh oh!

JackBoosY commented May 12, 2020

Uh oh!

jafrado commented May 12, 2020 via email

Uh oh!

jafrado commented May 12, 2020 via email

Uh oh!

jafrado commented Feb 13, 2020 •

edited

Loading

msftclas commented Feb 13, 2020 •

edited

Loading