[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries by Neumann-A · Pull Request #11550 · microsoft/vcpkg

Neumann-A · 2020-05-24T17:01:29Z

closes #11103

Testing with X windows PR (Linux)
Testing with X windows PR (Windows) (ran until xlib and than run into other problems)

JackBoosY · 2020-05-25T05:30:22Z

Maybe we should choose one port to test this PR?

ports/x264/portfile.cmake

This reverts commit 26269e9.

…_fixup_pkgconfig

Neumann-A · 2020-05-27T20:57:44Z

@JackBoosY: osx has no pkg-config installed?

JackBoosY · 2020-05-28T02:22:12Z

Yes, please install brew install pkgconfig here:

vcpkg/scripts/azure-pipelines/osx/azure-pipelines.yml

Line 25 in d9b4acf

brew list libtool || brew install libtool

Neumann-A · 2020-05-28T11:38:00Z

@JackBoosY: Done

JackBoosY · 2020-05-29T02:36:08Z

Looks good in my side.

azure-pipelines · 2020-07-13T20:44:57Z

Azure Pipelines successfully started running 1 pipeline(s).

…_fixup_pkgconfig

Neumann-A · 2020-07-14T05:47:17Z

currently checking why there is no regression in zstd. according to #12407 there should be a regression

- add additional debug messages for debuging - fix unsetting of cache variables hiding issues with debug libraries - fixed pkgconfig fix in the debug case

…fig_to_fixup_pkgconfig # Conflicts: # ports/zstd/CONTROL # ports/zstd/portfile.cmake

…ed (fixes some regressions) add option NOT_STATIC_PKGCONFIG to run pkg-config without the --static argument

…milar regex to the library removal for ignored flags.

Neumann-A · 2020-07-16T12:20:52Z

@ras0219-msft: Should have 561287c triggered a full rebuild after 5ccacd4?

Please rerun failing CIs. This PR should be green now.

BillyONeal · 2020-07-16T22:48:03Z

@Neumann-A Easiest way to force that is to push a merge with master; in this case there are merge conflicts

…_fixup_pkgconfig # Conflicts: # ports/zlib/CONTROL # ports/zlib/portfile.cmake

Neumann-A · 2020-07-17T07:11:19Z

The ompl:x86-windows regressions seems unrelated. Worked locally and error in CI is:

CMake Error at tests/CMakeLists.txt:16 (configure_file):
  configure_file Problem configuring file

JackBoosY · 2020-07-21T06:19:15Z

@ras0219-msft @ras0219 ping for merge this PR.

ras0219-msft · 2020-07-24T18:41:10Z

LGTM, thanks @Neumann-A for the continued awesome work on this!

I think that it will eventually make sense to move the "checking" parts of this into the vcpkg tool itself, to ensure it is always run on any .pc files left in the tree, but this is great for now.

…rosoft#11550) * [vcpkg/scripts/pkgconfig] rewrite pkgconfig check for libraries. * [vcpkg/scripts/pkgconfig] fix more details. * [vcpkg/scripts/pkgconfig] smaller improvements * ws change to check functionallity of script for testing. * [vcpkg/scripts/pkgconfig] update to latest test version * Revert "ws change to check functionallity of script for testing." This reverts commit 26269e9. * [nettle] bump control for vcpkg_fixup_pkgconfig test * [gmp] rerun CI to create new *.pc files * [gmp/nettle] enable port debug * [vcpkg/script/pkgconfig] fix path conversion regex for CI * [CI|OSX] install pkg-config on osx * [gmp/nettle] disable port debug * [vcpkg/scripts/pkgconfig] update to latest version of x windows pr * [zlib] add pkgconfig file * [zstd] add fixup pkgconfig * [libpng] add pc file installation * [bzip2] install pc file and leave a TODO for somebody else ;) * [bzip2] bump control * [vcpkg/scripts/pkgconfig] skip checks if pkgconfig cannot be found. - small bugfix in ignore flags regex * retry zstd and zlib * [libpng] retry by adding dl and m to system libraries for osx * [libpng] add missing vcpkg_fixup_pkgconfig() * [vcpkg/scripts/pkgconfig] unset var if found. fixes checks for other configurations which will be always succesful otherwise * [libpng] bump control * [libpng] enable port debug to debug osx regression * ws change to retrigger osx ci and hopeing that it works * fix typo * [libpng] remove -lm flag on apple platforms * ws change to rerun some ports in ci for good measure after the merge with master * Re-trigger CI test * [zstd] add pkgconfig * [zstd] correct debug link * [vcpkg/script/pkgconfig] - add more search suffixes for static libs - add additional debug messages for debuging - fix unsetting of cache variables hiding issues with debug libraries - fixed pkgconfig fix in the debug case * [pcre] add pthread dependency to pcre * [protobuf] fix pkgconfig * include quotes around the prefix in the case the prefix path was quoted (fixes some regressions) add option NOT_STATIC_PKGCONFIG to run pkg-config without the --static argument * [ignition-msgs5] get rid of a dev warning * [apr] fix apr regression * [protobuf] fix protobuf regression * [sdl1] fix regression due to variable expansion of pkg-config. Use similar regex to the library removal for ignored flags. * [ignition] fix regression * remove changes of zlib portfile. * reset changes in osx ci pipeline * add DISABLE_PARALLEL_CONFIGURE Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com> Co-authored-by: Billy Robert O'Neal <bion@microsoft.com>

Neumann-A added 3 commits May 24, 2020 19:00

[vcpkg/scripts/pkgconfig] rewrite pkgconfig check for libraries.

1008514

[vcpkg/scripts/pkgconfig] fix more details.

d841a1e

[vcpkg/scripts/pkgconfig] smaller improvements

d8b7e84

NancyLi1013 assigned JackBoosY May 25, 2020

ws change to check functionallity of script for testing.

26269e9

JackBoosY suggested changes May 26, 2020

View reviewed changes

ports/x264/portfile.cmake Outdated Show resolved Hide resolved

JackBoosY added the requires:author-response label May 26, 2020

JackBoosY changed the title ~~[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries.~~ [vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries May 26, 2020

Neumann-A added 4 commits May 27, 2020 15:52

[vcpkg/scripts/pkgconfig] update to latest test version

e678598

Revert "ws change to check functionallity of script for testing."

996511a

This reverts commit 26269e9.

Merge remote-tracking branch 'upstream/master' into use_pkg_config_to…

fd9966e

…_fixup_pkgconfig

[nettle] bump control for vcpkg_fixup_pkgconfig test

e063cce

Neumann-A added 3 commits May 27, 2020 23:05

[gmp] rerun CI to create new *.pc files

af1da99

[gmp/nettle] enable port debug

0fe0933

[vcpkg/script/pkgconfig] fix path conversion regex for CI

2b82a4e

JackBoosY added the depends:vm-update PR contains changes to the VM provisioning scripts label May 28, 2020

Neumann-A added 2 commits May 28, 2020 13:34

[CI|OSX] install pkg-config on osx

4fa4ee6

[gmp/nettle] disable port debug

0c2716c

Neumann-A marked this pull request as ready for review May 28, 2020 11:55

Neumann-A mentioned this pull request May 28, 2020

[qt5] update qt to 5.15 and make ports depend on qt5-base[core]. #11596

Merged

4 tasks

JackBoosY approved these changes May 29, 2020

View reviewed changes

JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:discussion and removed requires:author-response labels May 29, 2020

[vcpkg/scripts/pkgconfig] update to latest version of x windows pr

32b7b63

microsoft deleted a comment from azure-pipelines bot Jul 13, 2020

Neumann-A mentioned this pull request Jul 13, 2020

[glew] fix pkgconfig #12408

Closed

Merge remote-tracking branch 'upstream/master' into use_pkg_config_to…

ec93a0e

…_fixup_pkgconfig

Neumann-A added 10 commits July 14, 2020 08:27

[vcpkg/script/pkgconfig] - add more search suffixes for static libs

fac3c58

- add additional debug messages for debuging - fix unsetting of cache variables hiding issues with debug libraries - fixed pkgconfig fix in the debug case

Merge remote-tracking branch 'origin/zstd_pkgconfig' into use_pkg_con…

6a67a68

…fig_to_fixup_pkgconfig # Conflicts: # ports/zstd/CONTROL # ports/zstd/portfile.cmake

[pcre] add pthread dependency to pcre

80f1f27

[protobuf] fix pkgconfig

02b51be

include quotes around the prefix in the case the prefix path was quot…

c6985e4

…ed (fixes some regressions) add option NOT_STATIC_PKGCONFIG to run pkg-config without the --static argument

[ignition-msgs5] get rid of a dev warning

24f4f0c

[apr] fix apr regression

2f943f6

[protobuf] fix protobuf regression

4994797

[sdl1] fix regression due to variable expansion of pkg-config. Use si…

5ccacd4

…milar regex to the library removal for ignored flags.

[ignition] fix regression

561287c

Neumann-A added 3 commits July 17, 2020 00:51

Merge remote-tracking branch 'upstream/master' into use_pkg_config_to…

c1d11bc

…_fixup_pkgconfig # Conflicts: # ports/zlib/CONTROL # ports/zlib/portfile.cmake

remove changes of zlib portfile.

f5b63ca

reset changes in osx ci pipeline

fe3481c

add DISABLE_PARALLEL_CONFIGURE

cb63ab0

Sibras mentioned this pull request Jul 24, 2020

[ffmpeg] Add feature support for zlib, iconv, fdk-aac, mp3lame, opus, soxr, theora. #11277

Merged

ras0219-msft merged commit 458c20e into microsoft:master Jul 24, 2020

Neumann-A deleted the use_pkg_config_to_fixup_pkgconfig branch November 18, 2020 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries#11550

[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries#11550
ras0219-msft merged 56 commits intomicrosoft:masterfrom
Neumann-A:use_pkg_config_to_fixup_pkgconfig

Neumann-A commented May 24, 2020 •

edited

Loading

Uh oh!

JackBoosY commented May 25, 2020

Uh oh!

Uh oh!

Neumann-A commented May 27, 2020

Uh oh!

JackBoosY commented May 28, 2020

Uh oh!

Neumann-A commented May 28, 2020

Uh oh!

JackBoosY commented May 29, 2020

Uh oh!

azure-pipelines bot commented Jul 13, 2020

Uh oh!

Neumann-A commented Jul 14, 2020

Uh oh!

Neumann-A commented Jul 16, 2020 •

edited

Loading

Uh oh!

BillyONeal commented Jul 16, 2020

Uh oh!

Neumann-A commented Jul 17, 2020

Uh oh!

JackBoosY commented Jul 21, 2020

Uh oh!

ras0219-msft commented Jul 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Neumann-A commented May 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented May 25, 2020

Uh oh!

Uh oh!

Neumann-A commented May 27, 2020

Uh oh!

JackBoosY commented May 28, 2020

Uh oh!

Neumann-A commented May 28, 2020

Uh oh!

JackBoosY commented May 29, 2020

Uh oh!

azure-pipelines bot commented Jul 13, 2020

Uh oh!

Neumann-A commented Jul 14, 2020

Uh oh!

Neumann-A commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal commented Jul 16, 2020

Uh oh!

Neumann-A commented Jul 17, 2020

Uh oh!

JackBoosY commented Jul 21, 2020

Uh oh!

ras0219-msft commented Jul 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Neumann-A commented May 24, 2020 •

edited

Loading

Neumann-A commented Jul 16, 2020 •

edited

Loading