Skip to content

[ode] Bump version to 0.16.1#11029

Merged
ras0219-msft merged 1 commit into
microsoft:masterfrom
traversaro:bump-ode
Apr 27, 2020
Merged

[ode] Bump version to 0.16.1#11029
ras0219-msft merged 1 commit into
microsoft:masterfrom
traversaro:bump-ode

Conversation

@traversaro

Copy link
Copy Markdown
Contributor
  • What does your PR fix? Fixes issue #
    This PR increases the version of ode to 0.16.1 . Actually I looked into the ode port because I think there was a change in the hash in the tarball (possible due to hg --> git migration?) that caused the existing port to fail (see https://github.com/robotology/robotology-superbuild-dependencies-vcpkg/runs/618225302). However, as I saw that a new patch release went out, instead of just updating the hash of the old version I also bumper the port to the new version 0.16.1 .

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    I just updated the version, I do not think it will change the CI baseline.

  • Does your PR follow the maintainer guide?
    Yes

traversaro added a commit to robotology/robotology-superbuild-dependencies-vcpkg that referenced this pull request Apr 25, 2020
@traversaro

Copy link
Copy Markdown
Contributor Author

The osx CI job failed for the following error:

-- Downloading https://jaist.dl.sourceforge.net/project/geographiclib/distrib/archive/GeographicLib-1.47-patch1.zip...
-- Downloading https://jaist.dl.sourceforge.net/project/geographiclib/distrib/archive/GeographicLib-1.47-patch1.zip... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):
      
      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  ports/geographiclib/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

It seems a temporary network connection problem (I am able to save the file correctly from that URL) unrelated to this PR.

Comment thread ports/ode/portfile.cmake Outdated
@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 26, 2020
@ras0219-msft ras0219-msft merged commit 5852144 into microsoft:master Apr 27, 2020
@ras0219-msft

Copy link
Copy Markdown
Contributor

LGTM, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants