Skip to content

Build without ODE on Windows CI builds#1453

Merged
jslee02 merged 1 commit into
masterfrom
jslee02-patch-1
Apr 27, 2020
Merged

Build without ODE on Windows CI builds#1453
jslee02 merged 1 commit into
masterfrom
jslee02-patch-1

Conversation

@jslee02

@jslee02 jslee02 commented Apr 27, 2020

Copy link
Copy Markdown
Member

@traversaro

Copy link
Copy Markdown
Contributor

FYI the vcpkg upstream error should be fixed (once merged) by microsoft/vcpkg#11029 .

@jslee02

jslee02 commented Apr 27, 2020

Copy link
Copy Markdown
Member Author

@traversaro Wow, thanks! I should not merge this unless microsoft/vcpkg#11029 is not merged in time. 😄

@jslee02

jslee02 commented Apr 27, 2020

Copy link
Copy Markdown
Member Author

Well, on second thought, this should be merged for now because we use pre-installed vcpkg on GitHub Actions. 😞 Then revert once vcpkg is updated with your patch.

@traversaro

Copy link
Copy Markdown
Contributor

You probably already know about this, but to avoid this kind of problems you could try the GitHub Action cache feature (https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows). It is quite convenient and it also have a flexible invalidation mechanism (so you can decide if the cache is invalidate if the vcpkg version changes or just when you explicitly invalidate it).

@codecov

codecov Bot commented Apr 27, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1453 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1453   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         412      412           
  Lines       29923    29923           
=======================================
  Hits        17428    17428           
  Misses      12495    12495           

@jslee02

jslee02 commented Apr 27, 2020

Copy link
Copy Markdown
Member Author

It looks very promising! I know Travis and Appveyor support similar features but didn't know if GitHub Actions also supports it. Thanks!

@jslee02 jslee02 merged commit 9180d98 into master Apr 27, 2020
@jslee02 jslee02 deleted the jslee02-patch-1 branch April 27, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants