-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[poco] Update to 1.10.1 #10326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[poco] Update to 1.10.1 #10326
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd27d56
[poco] Update to 1.10.1
PhoebeHui 6617cbe
Merge from master
PhoebeHui 25f7514
Merge from master
PhoebeHui cc37a6e
Fix dependency pcre expat and sqlite3
PhoebeHui 1403f58
fix typo issue
PhoebeHui 4e8ed4e
Fix expat
PhoebeHui 0068774
Add vcpkg-cmake-wrapper.cmake for pcre
PhoebeHui dfe6560
Fix typo issue
PhoebeHui 9d4b2b0
Update ports/pcre/vcpkg-cmake-wrapper.cmake
PhoebeHui a53bdb6
Update the patch to use pcre export cmake targets
PhoebeHui 025b937
Undo changes for pcre
PhoebeHui 7c14f94
Merge branch 'master' into dev/Phoebe/poco
PhoebeHui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Source: pcre | ||
| Version: 8.44 | ||
| Port-Version: 7 | ||
| Port-Version: 8 | ||
| Homepage: https://www.pcre.org/ | ||
| Description: Perl Compatible Regular Expressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| include(SelectLibraryConfigurations) | ||
|
|
||
| find_path(PCRE_INCLUDE_DIR pcre.h) | ||
| find_library(PCRE_LIBRARY_DEBUG NAMES pcred NAMES_PER_DIR PATH_SUFFIXES lib PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug" NO_DEFAULT_PATH REQUIRED) | ||
| find_library(PCRE_LIBRARY_RELEASE NAMES pcre NAMES_PER_DIR PATH_SUFFIXES lib PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}" NO_DEFAULT_PATH REQUIRED) | ||
|
|
||
| select_library_configurations(PCRE) | ||
|
|
||
| set(PCRE_INCLUDE_DIRS ${PCRE_INCLUDE_DIR}) | ||
| set(PCRE_LIBRARIES ${PCRE_LIBRARY}) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index b664afd..0d4670e 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -457,15 +457,6 @@ install( | ||
| Devel | ||
| ) | ||
|
|
||
| -if(POCO_UNBUNDLED) | ||
| - install(FILES cmake/FindPCRE.cmake | ||
| - DESTINATION "${PocoConfigPackageLocation}") | ||
| - install(FILES cmake/V39/FindEXPAT.cmake | ||
| - DESTINATION "${PocoConfigPackageLocation}/V39") | ||
| - install(FILES cmake/V313/FindSQLite3.cmake | ||
| - DESTINATION "${PocoConfigPackageLocation}/V313") | ||
| -endif() | ||
| - | ||
| message(STATUS "CMake ${CMAKE_VERSION} successfully configured ${PROJECT_NAME} using ${CMAKE_GENERATOR} generator") | ||
| message(STATUS "${PROJECT_NAME} package version: ${PROJECT_VERSION}") | ||
| if(BUILD_SHARED_LIBS) | ||
| diff --git a/Data/SQLite/CMakeLists.txt b/Data/SQLite/CMakeLists.txt | ||
| index b52e2c5..0dcfae2 100644 | ||
| --- a/Data/SQLite/CMakeLists.txt | ||
| +++ b/Data/SQLite/CMakeLists.txt | ||
| @@ -7,7 +7,7 @@ file(GLOB_RECURSE HDRS_G "include/*.h") | ||
| POCO_HEADERS_AUTO(SQLITE_SRCS ${HDRS_G}) | ||
|
|
||
| if(POCO_UNBUNDLED) | ||
| - find_package(SQLite3 REQUIRED) | ||
| + find_package(unofficial-sqlite3 CONFIG REQUIRED) | ||
| else() | ||
| # sqlite3 | ||
| POCO_SOURCES(SQLITE_SRCS sqlite3 | ||
| @@ -43,7 +43,7 @@ target_include_directories(DataSQLite | ||
| ) | ||
|
|
||
| if(POCO_UNBUNDLED) | ||
| - target_link_libraries(DataSQLite PUBLIC SQLite::SQLite3) | ||
| + target_link_libraries(DataSQLite PUBLIC unofficial::sqlite3::sqlite3) | ||
| target_compile_definitions(DataSQLite PUBLIC | ||
| POCO_UNBUNDLED | ||
| SQLITE_THREADSAFE=1 | ||
| diff --git a/XML/CMakeLists.txt b/XML/CMakeLists.txt | ||
| index 4fbf06f..793285a 100644 | ||
| --- a/XML/CMakeLists.txt | ||
| +++ b/XML/CMakeLists.txt | ||
| @@ -20,7 +20,7 @@ endif() | ||
| # If POCO_UNBUNDLED is enabled we try to find the required packages | ||
| # The configuration will fail if the packages are not found | ||
| if(POCO_UNBUNDLED) | ||
| - find_package(EXPAT REQUIRED) | ||
| + find_package(expat CONFIG REQUIRED) | ||
| else() | ||
| POCO_SOURCES(SRCS expat | ||
| src/xmlparse.cpp | ||
| @@ -50,7 +50,7 @@ target_include_directories(XML | ||
| ) | ||
|
|
||
| if(POCO_UNBUNDLED) | ||
| - target_link_libraries(XML PUBLIC EXPAT::EXPAT) | ||
| + target_link_libraries(XML PUBLIC expat::expat) | ||
| target_compile_definitions(XML PUBLIC POCO_UNBUNDLED) | ||
| else() | ||
| if(WIN32) | ||
| diff --git a/cmake/PocoConfig.cmake.in b/cmake/PocoConfig.cmake.in | ||
| index 173eacd..589fdb6 100644 | ||
| --- a/cmake/PocoConfig.cmake.in | ||
| +++ b/cmake/PocoConfig.cmake.in | ||
| @@ -8,6 +8,13 @@ if (NOT Poco_FIND_COMPONENTS) | ||
| return() | ||
| endif() | ||
|
|
||
| +include(CMakeFindDependencyMacro) | ||
| +find_dependency(ZLIB REQUIRED) | ||
| +find_dependency(PCRE REQUIRED) | ||
| +if(Poco_FIND_REQUIRED_XML) | ||
| + find_dependency(EXPAT REQUIRED) | ||
| +endif() | ||
| + | ||
| set(_Poco_FIND_PARTS_REQUIRED) | ||
| if (Poco_FIND_REQUIRED) | ||
| set(_Poco_FIND_PARTS_REQUIRED REQUIRED) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,20 @@ | ||
| diff --git a/Foundation/CMakeLists.txt b/Foundation/CMakeLists.txt | ||
| index 26a2365..0b8f7bc 100644 | ||
| --- a/Foundation/CMakeLists.txt | ||
| +++ b/Foundation/CMakeLists.txt | ||
| @@ -168,6 +168,7 @@ target_link_libraries( "${LIBNAME}" ${SYSLIBS}) | ||
| target_include_directories( "${LIBNAME}" | ||
| PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
| + $<BUILD_INTERFACE:${PCRE_INCLUDE_DIRS}> | ||
| $<INSTALL_INTERFACE:include> | ||
| PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src | ||
| ) | ||
| diff --git a/Foundation/CMakeLists.txt b/Foundation/CMakeLists.txt | ||
| index 6b276be..0a3c63b 100644 | ||
| --- a/Foundation/CMakeLists.txt | ||
| +++ b/Foundation/CMakeLists.txt | ||
| @@ -101,13 +101,14 @@ set_target_properties(Foundation | ||
| ) | ||
|
|
||
| if(POCO_UNBUNDLED) | ||
| - target_link_libraries(Foundation PUBLIC Pcre::Pcre ZLIB::ZLIB) | ||
| + target_link_libraries(Foundation PUBLIC ${PCRE_LIBRARY} ZLIB::ZLIB) | ||
| target_compile_definitions(Foundation PUBLIC POCO_UNBUNDLED) | ||
| endif(POCO_UNBUNDLED) | ||
|
|
||
| target_include_directories(Foundation | ||
| PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
| + $<BUILD_INTERFACE:${PCRE_INCLUDE_DIRS}> | ||
| $<INSTALL_INTERFACE:include> | ||
| PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,27 @@ | ||
| diff --git a/Foundation/CMakeLists.txt b/Foundation/CMakeLists.txt | ||
| index 0b8f7bc..c362890 100644 | ||
| --- a/Foundation/CMakeLists.txt | ||
| +++ b/Foundation/CMakeLists.txt | ||
| @@ -53,6 +53,21 @@ if (POCO_UNBUNDLED) | ||
| include_directories(${ZLIB_INCLUDE_DIRS}) | ||
|
|
||
| add_definitions(-DPOCO_UNBUNDLED) | ||
| + add_definitions( | ||
| + -D_pcre_utf8_table1=_poco_pcre_utf8_table1 | ||
| + -D_pcre_utf8_table1_size=_poco_pcre_utf8_table1_size | ||
| + -D_pcre_utf8_table2=_poco_pcre_utf8_table2 | ||
| + -D_pcre_utf8_table3=_poco_pcre_utf8_table3 | ||
| + -D_pcre_utf8_table4=_poco_pcre_utf8_table4 | ||
| + -D_pcre_utt_names=_poco_pcre_utt_names | ||
| + -D_pcre_utt=_poco_pcre_utt | ||
| + -D_pcre_utt_size=_poco_pcre_utt_size | ||
| + -D_pcre_OP_lengths=_poco_pcre_OP_lengths | ||
| + -D_pcre_hspace_list=_poco_pcre_hspace_list | ||
| + -D_pcre_vspace_list=_poco_pcre_vspace_list | ||
| + -D_pcre_ucp_gentype=_poco_pcre_ucp_gentype | ||
| + -D_pcre_ucp_gbtable=_poco_pcre_ucp_gbtable | ||
| + ) | ||
|
|
||
| else() | ||
| # pcre | ||
| diff --git a/Foundation/CMakeLists.txt b/Foundation/CMakeLists.txt | ||
| index f7aca2b..6a3c120 100644 | ||
| --- a/Foundation/CMakeLists.txt | ||
| +++ b/Foundation/CMakeLists.txt | ||
| @@ -103,6 +103,22 @@ set_target_properties(Foundation | ||
| if(POCO_UNBUNDLED) | ||
| target_link_libraries(Foundation PUBLIC ${PCRE_LIBRARY} ZLIB::ZLIB) | ||
| target_compile_definitions(Foundation PUBLIC POCO_UNBUNDLED) | ||
| + add_definitions( | ||
| + -D_pcre_utf8_table1=_poco_pcre_utf8_table1 | ||
| + -D_pcre_utf8_table1_size=_poco_pcre_utf8_table1_size | ||
| + -D_pcre_utf8_table2=_poco_pcre_utf8_table2 | ||
| + -D_pcre_utf8_table3=_poco_pcre_utf8_table3 | ||
| + -D_pcre_utf8_table4=_poco_pcre_utf8_table4 | ||
| + -D_pcre_utt_names=_poco_pcre_utt_names | ||
| + -D_pcre_utt=_poco_pcre_utt | ||
| + -D_pcre_utt_size=_poco_pcre_utt_size | ||
| + -D_pcre_OP_lengths=_poco_pcre_OP_lengths | ||
| + -D_pcre_hspace_list=_poco_pcre_hspace_list | ||
| + -D_pcre_vspace_list=_poco_pcre_vspace_list | ||
| + -D_pcre_ucp_gentype=_poco_pcre_ucp_gentype | ||
| + -D_pcre_ucp_gbtable=_poco_pcre_ucp_gbtable | ||
| + ) | ||
| + | ||
| endif(POCO_UNBUNDLED) | ||
|
|
||
| target_include_directories(Foundation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index 5f8a2a6..1ffd0a0 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -195,8 +195,11 @@ if(EXISTS ${PROJECT_SOURCE_DIR}/Redis AND ENABLE_REDIS) | ||
| add_subdirectory(Redis) | ||
| list(APPEND Poco_COMPONENTS "Redis") | ||
| endif() | ||
| -if(EXISTS ${PROJECT_SOURCE_DIR}/PDF AND ENABLE_PDF) | ||
| -add_subdirectory(PDF) | ||
| +if(ENABLE_PDF) | ||
| +include(SelectLibraryConfigurations) | ||
| +find_library(PocoPDF_LIBRARY_RELEASE NAMES libhpdf) | ||
| +find_library(PocoPDF_LIBRARY_DEBUG NAMES libhpdfd) | ||
| +select_library_configurations(PocoPDF) | ||
| list(APPEND Poco_COMPONENTS "PDF") | ||
| endif() | ||
|
|
||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index b664afd..2174556 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -327,8 +327,11 @@ if(EXISTS ${PROJECT_SOURCE_DIR}/Redis AND ENABLE_REDIS) | ||
| list(APPEND Poco_COMPONENTS "Redis") | ||
| endif() | ||
| -if(EXISTS ${PROJECT_SOURCE_DIR}/PDF AND ENABLE_PDF) | ||
| - add_subdirectory(PDF) | ||
| +if(ENABLE_PDF) | ||
| + include(SelectLibraryConfigurations) | ||
| + find_library(PocoPDF_LIBRARY_RELEASE NAMES libhpdf) | ||
| + find_library(PocoPDF_LIBRARY_DEBUG NAMES libhpdfd) | ||
| + select_library_configurations(PocoPDF) | ||
| list(APPEND Poco_COMPONENTS "PDF") | ||
| endif() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.