Skip to content

[poco] Update to 1.10.1#10326

Merged
BillyONeal merged 12 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/poco
Oct 27, 2020
Merged

[poco] Update to 1.10.1#10326
BillyONeal merged 12 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/poco

Conversation

@PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Mar 6, 2020 •
edited
Loading

Related to #9964

  1. Update poco to latest release revision 1.10.1
  2. Update the patch static_pcre.patch and use-vcpkg-libharu.patch to adjust the source changes.
  3. Remove unused patch find_pcre.patch and fix_foundation_link.patch
  4. Add vcpkg-cmake-wrapper.cmake for pcre
  5. Add patch fix_dependency.patch to fix the dependency issue for sqlite3, pcre and expat.

Test:
find_package(Poco REQUIRED JWT Net XML Zip)
target_link_libraries(main PRIVATE Poco::JWT Poco::Net Poco::XML Poco::Zip)

All features test pass with x64-windows.
Skip features test on x64-linux since the dependency port is broken.

@PhoebeHui PhoebeHui added the wip label Mar 20, 2020
@linquize linquize mentioned this pull request Apr 30, 2020
Closed
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label May 22, 2020
@JackBoosY
Copy link
Contributor

JackBoosY commented Jun 9, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 9, 2020

Azure Pipelines failed to run 1 pipeline(s).

@KevDi
Copy link

KevDi commented Aug 17, 2020

Is there currently a plan when the Poco 1.10.1 Release is available in vcpkg?

@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Aug 17, 2020

I will continue to update this PR this week.

@PhoebeHui PhoebeHui marked this pull request as ready for review August 18, 2020 07:43
@BillyONeal
Copy link
Member

BillyONeal commented Aug 18, 2020

@PhoebeHui Looks like it's not happy :/

@PhoebeHui PhoebeHui mentioned this pull request Aug 21, 2020
Merged
@PhoebeHui PhoebeHui added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 21, 2020
@PhoebeHui PhoebeHui marked this pull request as draft August 21, 2020 02:51
@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Aug 21, 2020

The dependency port expat has usage issue which will be fixed by PR #13022, I will continue this work after the PR merged.

@PhoebeHui PhoebeHui marked this pull request as ready for review August 31, 2020 07:02
@PhoebeHui PhoebeHui marked this pull request as draft September 1, 2020 02:52
@PhoebeHui PhoebeHui added requires:all-feature-testing and removed depends:different-pr This PR or Issue depends on a PR which has been filed requires:author-response labels Sep 2, 2020
@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Sep 2, 2020

The json5-parser failures would be fixed by #10326

@PhoebeHui PhoebeHui marked this pull request as ready for review September 2, 2020 10:00
@BillyONeal
Copy link
Member

BillyONeal commented Sep 2, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 2, 2020

Azure Pipelines successfully started running 1 pipeline(s).

PhoebeHui
PhoebeHui commented Sep 3, 2020
View reviewed changes
BillyONeal
BillyONeal reviewed Sep 3, 2020
View reviewed changes
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 4, 2020
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Sep 11, 2020

Ping @PhoebeHui in case this was dropped

@ras0219-msft ras0219-msft marked this pull request as draft September 11, 2020 19:59
@PhoebeHui PhoebeHui removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 14, 2020
@PhoebeHui PhoebeHui mentioned this pull request Sep 15, 2020
Merged
@PhoebeHui PhoebeHui added the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 15, 2020
@PhoebeHui PhoebeHui mentioned this pull request Sep 23, 2020
Closed
@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Oct 21, 2020

This PR depends on PR #13539.

@PhoebeHui PhoebeHui marked this pull request as ready for review October 27, 2020 01:16
@PhoebeHui PhoebeHui removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 27, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 27, 2020
@BillyONeal BillyONeal merged commit b6b734c into microsoft:master Oct 27, 2020
@BillyONeal
Copy link
Member

BillyONeal commented Oct 27, 2020

Thanks for your contribution!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/poco branch October 27, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

+1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PhoebeHui @JackBoosY @KevDi @BillyONeal @ras0219-msft @strega-nil @NancyLi1013